Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254292: Update JMH devkit to 1.26 #575

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 9, 2020

It is currently at 1.21, and thus misses a bunch of fixes and improvements.

Testing:

  • Creating the JMH devkit
  • Using a new devkit with make test TEST=micro:RecordDeserialization

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/575/head:pull/575
$ git checkout pull/575

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 9, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2020

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label Oct 9, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 9, 2020

Webrevs

Loading

erikj79
erikj79 approved these changes Oct 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254292: Update JMH devkit to 1.26

Reviewed-by: erikj, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • d4b5dfd: 8253857: Shenandoah: Bugs in ShenandoahEvacOOMHandler related code
  • e9c1905: 8253740: [PPC64] Minor interpreter cleanup
  • b1448da: 8253900: SA: wrong size computation when JVM was built without AOT
  • 2bc8bc5: 8254265: s390 and linux 32 bit builds broken
  • 4f9a1ff: 8254073: Tokenizer improvements (revised)
  • 9cecc16: 8254244: Some code emitted by TemplateTable::branch is unused when running TieredCompilation
  • a95590d: 8254285: G1: Remove "What is this about" comment in G1CollectedHeap.cpp
  • 0230781: 8254175: Build no-pch configuration in debug mode for submit checks
  • b9873e1: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing
  • a2f6519: 8233685: Test tools/javac/modules/AddLimitMods.java fails
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/bc236903a29dcf0fc98fa6f68c214c9dacdf30c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 9, 2020
Copy link
Contributor

@theRealAph theRealAph left a comment

Works fine, thanks.

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 9, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2020

@shipilev Since your change was applied there have been 30 commits pushed to the master branch:

  • 2bbf8a2: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
  • aaa0a2a: 8254297: Zero and Minimal VMs are broken with undeclared identifier 'DerivedPointerTable' after JDK-8253180
  • 7e80c98: 8254261: fix javadocs in jdk.test.lib.Utils
  • d4b5dfd: 8253857: Shenandoah: Bugs in ShenandoahEvacOOMHandler related code
  • e9c1905: 8253740: [PPC64] Minor interpreter cleanup
  • b1448da: 8253900: SA: wrong size computation when JVM was built without AOT
  • 2bc8bc5: 8254265: s390 and linux 32 bit builds broken
  • 4f9a1ff: 8254073: Tokenizer improvements (revised)
  • 9cecc16: 8254244: Some code emitted by TemplateTable::branch is unused when running TieredCompilation
  • a95590d: 8254285: G1: Remove "What is this about" comment in G1CollectedHeap.cpp
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/bc236903a29dcf0fc98fa6f68c214c9dacdf30c2...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6d2c1a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8254292-jmh-1.26 branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants