Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274635: Use String.equals instead of String.compareTo in jdk.accessibility #5752

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 29, 2021

In several places, String.compareTo was compared with 0 ( via == 0).
Instead of this, we can use String.equals calls. String.equals is faster and shorter.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274635: Use String.equals instead of String.compareTo in jdk.accessibility

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5752/head:pull/5752
$ git checkout pull/5752

Update a local copy of the PR:
$ git checkout pull/5752
$ git pull https://git.openjdk.java.net/jdk pull/5752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5752

View PR using the GUI difftool:
$ git pr show -t 5752

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5752.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Sep 29, 2021
@mrserb
Copy link
Member

@mrserb mrserb commented Oct 1, 2021

Looks fine.

@turbanoff turbanoff changed the title [PATCH] Use String.equals instead of String.compareTo in jdk.accessibility 8274635: Use String.equals instead of String.compareTo in jdk.accessibility Oct 1, 2021
@openjdk openjdk bot added the rfr label Oct 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 1, 2021

Webrevs

mrserb
mrserb approved these changes Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274635: Use String.equals instead of String.compareTo in jdk.accessibility

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 3281102: 8268084: [macos] Disabled JMenuItem arrow is not disabled
  • 7957994: 8273695: Safepoint deadlock on VMOperation_lock
  • 9ca6bf0: 8274505: Too weak variable type leads to unnecessary cast in java.desktop
  • 0786d8b: 8268435: (ch) ChannelInputStream could override readAllBytes
  • bb4500d: 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures
  • 05d3860: 8274605: Fix predicate guarantees on returned values in (Doc)SourcePositions
  • 3d7671b: 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS
  • c05dc26: 8274435: EXCEPTION_ACCESS_VIOLATION in BFSClosure::closure_impl
  • cc14c6f: 8274227: Remove "impl.prefix" jdk system property usage from InetAddress
  • 292d7bb: 8274363: Transitively sealed classes not considered exhaustive in switches
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/aaa36cc0069043e34b47e89769eb9eba39e5362a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 1, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 4, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@turbanoff
Your change (at version 08f781c) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 5, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

Going to push as commit 53d7e95.
Since your change was applied there have been 52 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@mrserb @turbanoff Pushed as commit 53d7e95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the use_String.equals_instead_of_String.compareTo_jdk.accessibility branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
2 participants