8274227: Remove "impl.prefix" jdk system property usage from InetAddress

[AlekseiEfimov]

The following fix proposes to remove usages of "impl.prefix" JDK system property from the java.net.InetAddress class.
This system property is used to locate concrete implementations of the package private "java.net.InetAddressImpl" interface.

The list of changes:

• impl.prefix usages are removed
• InetAddressImpl made sealed interface by only allowing default implementations available in 'java.net' package: Inet4AddressImpl and Inet6AddressImpl.

tier1-tier3 tests show no failures with this fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274227: Remove "impl.prefix" jdk system property usage from InetAddress

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5755/head:pull/5755
$ git checkout pull/5755

Update a local copy of the PR:
$ git checkout pull/5755
$ git pull https://git.openjdk.java.net/jdk pull/5755/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5755

View PR using the GUI difftool:
$ git pr show -t 5755

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5755.diff

[bridgekeeper]

👋 Welcome back aefimov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlekseiEfimov The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1f08a755)

[AlanBateman]

/csr

[AlanBateman]

This looks fine. I've added the CSR label as I think we should create a CSR to track this removal (it was completely undocumented/unsupported and also required adding classes to java.base/java.net so there should be no issue).

[openjdk]

@AlanBateman this pull request will not be integrated until the CSR request JDK-8274230 for issue JDK-8274227 has been approved.

[dfuch]

LGTM too. Good to see this old code go away!

[openjdk]

@AlekseiEfimov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274227: Remove "impl.prefix" jdk system property usage from InetAddress

Reviewed-by: alanb, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 2e690ba: 8274322: Problems with oopDesc construction
• a8edd1b: 8274527: Minimal VM build fails after JDK-8273459
• 7326481: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs
• 8215b2e: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs
• 9573022: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
• f08180f: 8274501: c2i entry barriers read int as long on AArch64
• c57ed22: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation
• 9180d9a: 8273216: JCMD does not work across container boundaries with Podman
• 3e0d7c3: 8270290: NTLM authentication fails if HEAD request is used
• bfd6163: 8274196: Crashes in VM_HeapDumper::work after JDK-8252842
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/c4d115701d102c33af937ca25dda8ac50117ac6b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlekseiEfimov]

/integrate

[openjdk]

Going to push as commit cc14c6f.
Since your change was applied there have been 30 commits pushed to the master branch:

• 292d7bb: 8274363: Transitively sealed classes not considered exhaustive in switches
• 1887028: 8269113: Javac throws when compiling switch (null)
• b7b78ff: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines
• 5e4b514: 8274550: c2i entry barriers read int as long on PPC
• 2e690ba: 8274322: Problems with oopDesc construction
• a8edd1b: 8274527: Minimal VM build fails after JDK-8273459
• 7326481: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs
• 8215b2e: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs
• 9573022: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
• f08180f: 8274501: c2i entry barriers read int as long on AArch64
• ... and 20 more: https://git.openjdk.java.net/jdk/compare/c4d115701d102c33af937ca25dda8ac50117ac6b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlekseiEfimov Pushed as commit cc14c6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.