Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274525: Replace uses of StringBuffer with StringBuilder in java.xml #5759

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Sep 29, 2021

StringBuffer is a legacy synchronized class. There are more modern alternatives which perform better:

  1. Plain String concatenation should be preferred
  2. StringBuilder is a direct replacement to StringBuffer which generally have better performance

Similar cleanups:

  1. JDK-8264029 java.base
  2. JDK-8264428 java.desktop
  3. JDK-8264484 jdk.hotspot.agent

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274525: Replace uses of StringBuffer with StringBuilder in java.xml

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5759/head:pull/5759
$ git checkout pull/5759

Update a local copy of the PR:
$ git checkout pull/5759
$ git pull https://git.openjdk.java.net/jdk pull/5759/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5759

View PR using the GUI difftool:
$ git pr show -t 5759

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5759.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Sep 29, 2021
@turbanoff turbanoff changed the title [PATCH] Cleanup usages of StringBuffer in java.xml 8274525: Replace uses of StringBuffer with StringBuilder in java.xml Sep 29, 2021
@openjdk openjdk bot added the rfr label Sep 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274525: Replace uses of StringBuffer with StringBuilder in java.xml

Reviewed-by: joehw, iris, naoto, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 292d7bb: 8274363: Transitively sealed classes not considered exhaustive in switches
  • 1887028: 8269113: Javac throws when compiling switch (null)
  • b7b78ff: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines
  • 5e4b514: 8274550: c2i entry barriers read int as long on PPC
  • 2e690ba: 8274322: Problems with oopDesc construction
  • a8edd1b: 8274527: Minimal VM build fails after JDK-8273459
  • 7326481: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs
  • 8215b2e: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs
  • 9573022: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
  • f08180f: 8274501: c2i entry barriers read int as long on AArch64
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/97b28742b4d3083cadbe4dc10b625ec9fb944353...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JoeWang-Java, @irisclark, @naotoj, @dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 30, 2021
naotoj
naotoj approved these changes Sep 30, 2021
dfuch
dfuch approved these changes Oct 1, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 1, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@turbanoff
Your change (at version 69af74f) is now ready to be sponsored by a Committer.

@dfuch
Copy link
Member

@dfuch dfuch commented Oct 6, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

Going to push as commit 754bc82.
Since your change was applied there have been 82 commits pushed to the master branch:

  • 4e7d7ca: 8273711: Remove redundant stream() call before forEach in jdk.jlink
  • f3cedbe: 8274464: Remove redundant stream() call before forEach in java.* modules
  • c10de35: 8262944: Improve exception message when automatic module lists provider class not in JAR file
  • b8af6a9: 8273917: Remove 'leaf' ranking for Mutex
  • c80a612: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • 9759fcb: 8274496: Use String.contains() instead of String.indexOf() in java.desktop
  • cdf8930: 8274625: Search field placeholder behavior
  • df125f6: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"
  • c74726d: 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297
  • 2faced0: 8274738: ZGC: Use relaxed atomic load when reading bits in the live map
  • ... and 72 more: https://git.openjdk.java.net/jdk/compare/97b28742b4d3083cadbe4dc10b625ec9fb944353...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@dfuch @turbanoff Pushed as commit 754bc82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the cleanup_usages_of_StringBuffer_in_java.xml branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
5 participants