Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274560: JFR: Add test for OldObjectSample event when using Shenandoah #5773

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 30, 2021

Similar to JDK-8248302, we would like to have a test for Shenandoah. Current jdk/jfr/event/oldobject/TestObjectDescription.java fails with Shenandoah and should be excluded.

Additional testing:

  • jdk/jfr/event/oldobject/TestObjectDescription.java, default: still passes
  • jdk/jfr/event/oldobject/TestObjectDescription.java, -XX:+UseShenandoahGC: now skipped
  • jdk/jfr/event/oldobject/TestObjectDescription.java, -XX:+UseZGC: still skipped
  • jdk/jfr/event/oldobject/TestShenandoah.java, out of box: passes
  • jdk/jfr/event/oldobject/TestShenandoah.java, -XX:+UseShenandoahGC: passes
  • jdk/jfr/event/oldobject/TestShenandoah.java, -XX:+UseZGC: skipped

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274560: JFR: Add test for OldObjectSample event when using Shenandoah

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5773/head:pull/5773
$ git checkout pull/5773

Update a local copy of the PR:
$ git checkout pull/5773
$ git pull https://git.openjdk.java.net/jdk pull/5773/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5773

View PR using the GUI difftool:
$ git pr show -t 5773

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5773.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Sep 30, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Oct 11, 2021

Any takers? :)

Copy link

@mgronlun mgronlun left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 11, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274560: JFR: Add test for OldObjectSample event when using Shenandoah

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 155 new commits pushed to the master branch:

  • 75f5145: 8274925: Shenandoah: shenandoah/TestAllocHumongousFragment.java test failed on lock rank check
  • 83c3771: 8273881: Metaspace: test repeated deallocations
  • 3f01d03: 8275021: Test serviceability/sa/TestJmapCore.java fails with: java.io.IOException: Stack frame 0x4 not found
  • 3f07337: 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests
  • 0d80f6c: 8274379: Allow process of unsafe access errors in check_special_condition_for_native_trans
  • b870468: 8274347: Passing a nested switch expression as a parameter causes an NPE during compile
  • 110e38d: 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes
  • b7af890: 8274430: Remove some debug error printing code added in JDK-8017163
  • aaf2401: 8274927: Remove unnecessary G1ArchiveAllocator code
  • c55dd36: 8275008: gtest build failure due to stringop-overflow warning with gcc11
  • ... and 145 more: https://git.openjdk.java.net/jdk/compare/79865cd797737f22cd4efe7e9c03ddbb86095e64...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2021
@shipilev
Copy link
Member Author

shipilev commented Oct 12, 2021

Thank you!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2021

Going to push as commit ef0922e.
Since your change was applied there have been 158 commits pushed to the master branch:

  • 1e30695: 8274466: G1: use field directly rather than method in G1CollectorState::in_mixed_phase
  • dd93c6e: 8272167: AbsPathsInImage.java should skip *.dSYM directories
  • 829dea4: 8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop
  • 75f5145: 8274925: Shenandoah: shenandoah/TestAllocHumongousFragment.java test failed on lock rank check
  • 83c3771: 8273881: Metaspace: test repeated deallocations
  • 3f01d03: 8275021: Test serviceability/sa/TestJmapCore.java fails with: java.io.IOException: Stack frame 0x4 not found
  • 3f07337: 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests
  • 0d80f6c: 8274379: Allow process of unsafe access errors in check_special_condition_for_native_trans
  • b870468: 8274347: Passing a nested switch expression as a parameter causes an NPE during compile
  • 110e38d: 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes
  • ... and 148 more: https://git.openjdk.java.net/jdk/compare/79865cd797737f22cd4efe7e9c03ddbb86095e64...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@shipilev Pushed as commit ef0922e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8274560-shenandoah-jfr-oldobjectsample branch Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants