Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS #5782

Closed

Conversation

bplb
Copy link
Member

@bplb bplb commented Sep 30, 2021

Add extended attributes to capabilities flag if _SYS_XATTR_H is defined.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5782/head:pull/5782
$ git checkout pull/5782

Update a local copy of the PR:
$ git checkout pull/5782
$ git pull https://git.openjdk.java.net/jdk pull/5782/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5782

View PR using the GUI difftool:
$ git pr show -t 5782

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5782.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio label Sep 30, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 1, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 108 new commits pushed to the master branch:

  • 2e690ba: 8274322: Problems with oopDesc construction
  • a8edd1b: 8274527: Minimal VM build fails after JDK-8273459
  • 7326481: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs
  • 8215b2e: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs
  • 9573022: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
  • f08180f: 8274501: c2i entry barriers read int as long on AArch64
  • c57ed22: 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation
  • 9180d9a: 8273216: JCMD does not work across container boundaries with Podman
  • 3e0d7c3: 8270290: NTLM authentication fails if HEAD request is used
  • bfd6163: 8274196: Crashes in VM_HeapDumper::work after JDK-8252842
  • ... and 98 more: https://git.openjdk.java.net/jdk/compare/603138895f1665e75f01bb787af3222f08abc4db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 1, 2021
@bplb
Copy link
Member Author

bplb commented Oct 1, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 1, 2021

Going to push as commit 3d7671b.
Since your change was applied there have been 114 commits pushed to the master branch:

  • c05dc26: 8274435: EXCEPTION_ACCESS_VIOLATION in BFSClosure::closure_impl
  • cc14c6f: 8274227: Remove "impl.prefix" jdk system property usage from InetAddress
  • 292d7bb: 8274363: Transitively sealed classes not considered exhaustive in switches
  • 1887028: 8269113: Javac throws when compiling switch (null)
  • b7b78ff: 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines
  • 5e4b514: 8274550: c2i entry barriers read int as long on PPC
  • 2e690ba: 8274322: Problems with oopDesc construction
  • a8edd1b: 8274527: Minimal VM build fails after JDK-8273459
  • 7326481: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs
  • 8215b2e: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs
  • ... and 104 more: https://git.openjdk.java.net/jdk/compare/603138895f1665e75f01bb787af3222f08abc4db...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 1, 2021
@openjdk
Copy link

openjdk bot commented Oct 1, 2021

@bplb Pushed as commit 3d7671b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the UserDefinedAttributeView-xattr-8274562 branch Oct 1, 2021
@Dmor01
Copy link

Dmor01 commented Oct 1, 2021

@bplb would it be possible to get the fix for 8274562 backported to JDK17?

@mlbridge
Copy link

mlbridge bot commented Oct 2, 2021

Mailing list message from Brian Burkhalter on nio-dev:

On Oct 1, 2021, at 4:50 PM, Dmor01 <github.com+30833588+dmor01 at openjdk.java.net<mailto:github.com+30833588+dmor01 at openjdk.java.net>> wrote:

On Thu, 30 Sep 2021 21:03:14 GMT, Brian Burkhalter <bpb at openjdk.org<mailto:bpb at openjdk.org>> wrote:

Add extended attributes to capabilities flag if `_SYS_XATTR_H` is defined.

@bplb would it be possible to get the fix for 8274562 backported to JDK17?

I hope so. I?ll put the topic in my list for next week.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20211002/d421a591/attachment-0001.htm>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated nio
3 participants