Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274610: Add linux-aarch64 to bootcycle build profiles #5783

Conversation

mseledts
Copy link
Member

@mseledts mseledts commented Sep 30, 2021

Please review this simple/trivial change that add linux-aarch64 platform to bootcycle build profiles.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274610: Add linux-aarch64 to bootcycle build profiles

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5783/head:pull/5783
$ git checkout pull/5783

Update a local copy of the PR:
$ git checkout pull/5783
$ git pull https://git.openjdk.java.net/jdk pull/5783/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5783

View PR using the GUI difftool:
$ git pr show -t 5783

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5783.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 30, 2021

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@mseledts The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Sep 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 30, 2021

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274610: Add linux-aarch64 to bootcycle build profiles

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 7326481: 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs
  • 8215b2e: 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 30, 2021
@mseledts
Copy link
Member Author

@mseledts mseledts commented Oct 4, 2021

Thank you Erik.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

Going to push as commit 9914e5c.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 0ca094b: 8273244: Improve diagnostic output related to ErroneousTree
  • 6f727d8: 8274666: rename HtmlStyle.descfrmTypeLabel to be less cryptic
  • 139a833: 8268869: java in source-file mode suggests javac-only Xlint flags
  • f63c4a8: 8274471: Verification of OCSP Response signed with RSASSA-PSS fails
  • f2404d6: 8274658: ISO 4217 Amendment 170 Update
  • 7eb0372: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test
  • 47bfc8a: 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening
  • 0828273: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected
  • 6726c59: 8274634: Use String.equals instead of String.compareTo in java.desktop
  • 3281102: 8268084: [macos] Disabled JMenuItem arrow is not disabled
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/9573022978bfeff55b51fa6f30027f59a0783d31...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@mseledts Pushed as commit 9914e5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
2 participants