New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274615: Support relaxed atomic add for linux-aarch64 #5785
Conversation
|
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/label add aarch64-port-dev |
@kimbarrett The label
|
Webrevs
|
ping? @theRealAph ? |
@kimbarrett This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Hi Kim,
Not an ARM expert but seeing as this just elides the dmb this looks fine.
Thanks,
David
Thanks @theRealAph and @dholmes-ora for reviews. |
/integrate |
@kimbarrett Pushed as commit 8de2636. |
Please review this change to the linux-aarch64 port to support relaxed
atomic add operations. Both ldxr/stxr and LSE-based implementations are
provided. The appropriate one to use selected at runtime, using the existing
infrastructure for that selection.
Testing:
mach5 tier1-3
Some hand-checked performance and functional testing that both LSE and
non-LSE implementations work, and that the relaxed operations are faster
than the conservative default.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5785/head:pull/5785
$ git checkout pull/5785
Update a local copy of the PR:
$ git checkout pull/5785
$ git pull https://git.openjdk.java.net/jdk pull/5785/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5785
View PR using the GUI difftool:
$ git pr show -t 5785
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5785.diff