Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274615: Support relaxed atomic add for linux-aarch64 #5785

Closed
wants to merge 2 commits into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Oct 1, 2021

Please review this change to the linux-aarch64 port to support relaxed
atomic add operations. Both ldxr/stxr and LSE-based implementations are
provided. The appropriate one to use selected at runtime, using the existing
infrastructure for that selection.

Testing:
mach5 tier1-3
Some hand-checked performance and functional testing that both LSE and
non-LSE implementations work, and that the relaxed operations are faster
than the conservative default.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274615: Support relaxed atomic add for linux-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5785/head:pull/5785
$ git checkout pull/5785

Update a local copy of the PR:
$ git checkout pull/5785
$ git pull https://git.openjdk.java.net/jdk pull/5785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5785

View PR using the GUI difftool:
$ git pr show -t 5785

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5785.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 1, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Oct 1, 2021
@kimbarrett kimbarrett marked this pull request as ready for review Oct 1, 2021
@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Oct 1, 2021

/label add aarch64-port-dev

@openjdk openjdk bot added the rfr label Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@kimbarrett The label aarch64-port is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 1, 2021

Webrevs

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Oct 8, 2021

ping? @theRealAph ?

Copy link
Contributor

@theRealAph theRealAph left a comment

Looks good, thanks.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274615: Support relaxed atomic add for linux-aarch64

Reviewed-by: aph, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7d2633f: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 8, 2021
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Kim,

Not an ARM expert but seeing as this just elides the dmb this looks fine.

Thanks,
David

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Oct 12, 2021

Thanks @theRealAph and @dholmes-ora for reviews.

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Oct 12, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

Going to push as commit 8de2636.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7d2633f: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@kimbarrett Pushed as commit 8de2636.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the aarch64_touch_exp branch Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
3 participants