8274456 : Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java

[lawrence-andrew]

1. Removed =yesno
2. After running the test case, test UI will close immediately. Where the user cannot interact so rewrote the test case.
   a) Toolkit Modal Dialog will be shown after clicking the show button.
   b) Added timeout & tested
   c) Step by step instruction what the user has to perform

@shurymury

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5789/head:pull/5789
$ git checkout pull/5789

Update a local copy of the PR:
$ git checkout pull/5789
$ git pull https://git.openjdk.java.net/jdk pull/5789/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5789

View PR using the GUI difftool:
$ git pr show -t 5789

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5789.diff

[bridgekeeper]

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lawrence-andrew The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (88d27006)
• 00: Full (d525bb33)

[mrserb]

A few comments:

• Looks like you invert the assertion in the test:
  old: "The test fails if the page dialog blocks the toolkit"
  new: "Check if page dialog blocks the 'Toolkit modal dialog'. If yes, then test Pass else test fail."
• Please update the copyright date

[lawrence-andrew]

@mrserb , fixed the instruction and the copyright date.

[openjdk]

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• 8a4d2b4: 8274680: Remove unnecessary conversion to String in java.desktop
• 986ee5d: 8274670: Improve version string handling in SA
• df7b0c7: 8274715: Implement forEach in Collections.CopiesList
• d4e8712: 8274797: ProblemList resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java on macosx-x64
• 4726267: 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287
• 83b2219: 8273612: Fix for JDK-8272873 causes timeout in running some tests with -Xcomp
• d34ec6c: 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net
• 332f067: 8274729: Define Position.NOPOS == Diagnostic.NOPOS
• 1e75203: 8274656: Remove default_checksum and safe_checksum_type from krb5.conf
• 03d3c03: 8273670: Remove weak etypes from default krb5 etype list
• ... and 44 more: https://git.openjdk.java.net/jdk/compare/7326481143c1321700cbf2caa9e068c5077e22c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lawrence-andrew]

/integrate

[openjdk]

@lawrence-andrew
Your change (at version 88d2700) is now ready to be sponsored by a Committer.

[mrserb]

/integrate

[openjdk]

@mrserb Only the author (@lawrence-andrew) is allowed to issue the integrate command. As this PR is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[mrserb]

/sponsor

[openjdk]

Going to push as commit d57fb6f.
Since your change was applied there have been 68 commits pushed to the master branch:

• 734d1fb: 8274211: Test man page that options are documented
• 9561fea: 8273102: Delete deprecated for removal the empty finalize() in java.desktop module
• 9945f7a: 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management
• 754bc82: 8274525: Replace uses of StringBuffer with StringBuilder in java.xml
• 4e7d7ca: 8273711: Remove redundant stream() call before forEach in jdk.jlink
• f3cedbe: 8274464: Remove redundant stream() call before forEach in java.* modules
• c10de35: 8262944: Improve exception message when automatic module lists provider class not in JAR file
• b8af6a9: 8273917: Remove 'leaf' ranking for Mutex
• c80a612: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
• 9759fcb: 8274496: Use String.contains() instead of String.indexOf() in java.desktop
• ... and 58 more: https://git.openjdk.java.net/jdk/compare/7326481143c1321700cbf2caa9e068c5077e22c4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb @lawrence-andrew Pushed as commit d57fb6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.