Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254319: Shenandoah: Interpreter native-LRB needs to activate during HAS_FORWARDED #579

Closed
wants to merge 2 commits into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Oct 9, 2020

We currently only activate native-LRB when EVACUATING, however we need it to activate during all of HAS_FORWARDED because it may have to resolve the target.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ❌ (1/5 failed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Build / test ⏳ (1/1 running)
Test (tier1) ⏳ (3/9 running) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8254319: Shenandoah: Interpreter native-LRB needs to activate during HAS_FORWARDED

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/579/head:pull/579
$ git checkout pull/579

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2020

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2020
@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@rkennke The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 9, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2020

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Looks good.

@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254319: Shenandoah: Interpreter native-LRB needs to activate during HAS_FORWARDED

Reviewed-by: shade, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • be26972: 8253379: [windows] Several jpackage tests failed with error code 1638

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 9, 2020
@rkennke
Copy link
Contributor Author

rkennke commented Oct 9, 2020

/integrate

@openjdk openjdk bot closed this Oct 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 9, 2020
@openjdk
Copy link

openjdk bot commented Oct 9, 2020

@rkennke Since your change was applied there has been 1 commit pushed to the master branch:

  • be26972: 8253379: [windows] Several jpackage tests failed with error code 1638

Your commit was automatically rebased without conflicts.

Pushed as commit 536b35b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
3 participants