8274806: Simplify equals() call on nullable variable and a constant in java.desktop

[turbanoff]

Flipping arguments of 'equals' method, allows simplifying boolean expressions: now we can remove redundant null check before.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274806: Simplify equals() call on nullable variable and a constant in java.desktop

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Pankaj Bansal (@pankaj-bansal - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5794/head:pull/5794
$ git checkout pull/5794

Update a local copy of the PR:
$ git checkout pull/5794
$ git pull https://git.openjdk.java.net/jdk pull/5794/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5794

View PR using the GUI difftool:
$ git pr show -t 5794

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5794.diff

[bridgekeeper]

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following labels will be automatically applied to this pull request:

• client
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mrserb]

Looks fine

[mlbridge]

Webrevs

• 00: Full (02b25450)

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274806: Simplify equals() call on nullable variable and a constant in java.desktop

Reviewed-by: serb, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

• b60837a: 8272586: emit abstract machine code in hs-err logs
• 97ea9dd: 8274840: Update OS detection code to recognize Windows 11
• 8de7763: 8273152: Refactor CDS FileMapHeader loading code
• 920e707: 8274920: ProblemList 2 VectorAPI tests failing due to "assert(!vbox->is_Phi()) failed"
• 7de2cf8: 8273910: Redundant condition and assignment in java.net.URI
• 8ca0846: 8274407: (tz) Update Timezone Data to 2021c
• 4ab274a: 8274858: Remove unused dictionary_classes_do functions
• 03a8d34: 8273826: Correct Manifest file name and NPE checks
• 722d639: 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows
• 340c715: 8273929: Remove GzipRandomAccess in heap dump test
• ... and 62 more: https://git.openjdk.java.net/jdk/compare/9ca6bf0d22ac39d4ee29c756903038f09087ca12...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @pankaj-bansal) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[pankaj-bansal]

looks good to me

[turbanoff]

/integrate

[openjdk]

@turbanoff
Your change (at version 02b2545) is now ready to be sponsored by a Committer.

[mrserb]

/sponsor

[openjdk]

Going to push as commit f640c7a.
Since your change was applied there have been 80 commits pushed to the master branch:

• 9c431dd: 8274900: Too weak variable type leads to unnecessary cast in jdk.javadoc
• 3cb9724: 8274934: Attempting to acquire lock JNICritical_lock/41 out of order with lock MultiArray_lock/41
• 239a35a: 8233749: Files.exists javadoc doesn't mention eating IOException
• ec19907: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile
• ccbce10: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop
• 36b89a1: 8274785: ciReplay: Potential crash due to uninitialized Compile::_ilt variable
• 2aacd42: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
• 6364719: 8274004: Change 'nonleaf' rank name
• b60837a: 8272586: emit abstract machine code in hs-err logs
• 97ea9dd: 8274840: Update OS detection code to recognize Windows 11
• ... and 70 more: https://git.openjdk.java.net/jdk/compare/9ca6bf0d22ac39d4ee29c756903038f09087ca12...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb @turbanoff Pushed as commit f640c7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.