8275079: Remove unnecessary conversion to String in java.net.http

[turbanoff]

Cleanup unnecessary String.valueOf calls (and similar) when conversion will happen implicitly anyway

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8275079: Remove unnecessary conversion to String in java.net.http

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5795/head:pull/5795
$ git checkout pull/5795

Update a local copy of the PR:
$ git checkout pull/5795
$ git pull https://git.openjdk.java.net/jdk pull/5795/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5795

View PR using the GUI difftool:
$ git pr show -t 5795

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5795.diff

[bridgekeeper]

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following labels will be automatically applied to this pull request:

• net
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[wangweij]

Some small comments.

[mlbridge]

Webrevs

• 00: Full (6e4c4671)

[dfuch]

LGTM

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275079: Remove unnecessary conversion to String in java.net.http

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

• 124f823: 8268764: Use Long.hashCode() instead of int-cast where applicable
• 8657f77: 8271514: support JFR use of new ThreadsList::Iterator
• b8bd259: 8271737: Only normalize the cached user.dir property once
• 89999f7: 8275131: Exceptions after a touchpad gesture on macOS
• 07b1f1c: 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6
• f623460: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception"
• e393c5e: 8275074: Cleanup unused code in JFR LeakProfiler
• e16b93a: 8274770: [PPC64] resolve_jobject needs a generic implementation to support load barriers
• 1ab6414: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag
• b460d6d: 8275091: /src/jdk.management.jfr/share/classes/module-info.java has non-canonical order
• ... and 111 more: https://git.openjdk.java.net/jdk/compare/9ca6bf0d22ac39d4ee29c756903038f09087ca12...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij, @dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dfuch]

Hi Andrey - I will sponsor this change.

[turbanoff]

/integrate

[openjdk]

@turbanoff
Your change (at version 6e4c467) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit 19f76c2.
Since your change was applied there have been 298 commits pushed to the master branch:

• e5cd269: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info
• 82f4aac: 8259609: C2: optimize long range checks in long counted loops
• 574f890: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak
• 7c88a59: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]
• c9dec2f: 8273299: Unnecessary Vector usage in java.security.jgss
• b98ed55: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective
• 71d593e: 8275162: Use varargs in 'def' macros in mutexLocker.cpp
• 7ca053d: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
• 4be88d5: 8275047: Optimize existing fill stubs for AVX-512 target
• 63e0f34: 8275767: JDK source code contains redundant boolean operations in jdk.charsets
• ... and 288 more: https://git.openjdk.java.net/jdk/compare/9ca6bf0d22ac39d4ee29c756903038f09087ca12...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @turbanoff Pushed as commit 19f76c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.