8274721: UnixSystem fails to provide uid, gid or groups if no username is available

[wangweij]

Two changes:

1. Calculation of groups is put in a separate block.
2. Add fallback for uid and gid

No regression test. Hard to reproduce bud reporter's environment in jtreg.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274721: UnixSystem fails to provide uid, gid or groups if no username is available

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5808/head:pull/5808
$ git checkout pull/5808

Update a local copy of the PR:
$ git checkout pull/5808
$ git pull https://git.openjdk.java.net/jdk pull/5808/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5808

View PR using the GUI difftool:
$ git pr show -t 5808

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5808.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (711cc521)

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274721: UnixSystem fails to provide uid, gid or groups if no username is available

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 168 new commits pushed to the master branch:

• 1afddb2: 8275322: Change nested classes in java.management to static nested classes
• 45ebf85: 8275333: Print count in "Too many recored phases?" assert
• ebb1363: 8251513: Code around Parse::do_lookupswitch/do_tableswitch should be cleaned up
• bb7dacd: 8275334: Move class loading Events to a separate section in hs_err files
• 3150069: 8271949: dumppath in -XX:FlightRecorderOptions does not affect
• bfcf6a2: 8275277: assert(dest_attr.is_in_cset() == (obj->forwardee() == obj)) failed: Only evac-failed objects must be in the collection set here but is not
• 96fef40: 8189591: No way to locally suppress doclint warnings
• 7fc3a8d: 8275149: (ch) ReadableByteChannel returned by Channels.newChannel(InputStream) throws ReadOnlyBufferException
• 831802d: 8275163: Deflater::deflate methods omit javadoc for ReadOnlyBufferException
• ad9e234: 8275145: file.encoding system property has an incorrect value on Windows
• ... and 158 more: https://git.openjdk.java.net/jdk/compare/0786d8b7b367e3aa3ffa54a3e339572938378dca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

/integrate

[openjdk]

Going to push as commit a619f89.
Since your change was applied there have been 168 commits pushed to the master branch:

• 1afddb2: 8275322: Change nested classes in java.management to static nested classes
• 45ebf85: 8275333: Print count in "Too many recored phases?" assert
• ebb1363: 8251513: Code around Parse::do_lookupswitch/do_tableswitch should be cleaned up
• bb7dacd: 8275334: Move class loading Events to a separate section in hs_err files
• 3150069: 8271949: dumppath in -XX:FlightRecorderOptions does not affect
• bfcf6a2: 8275277: assert(dest_attr.is_in_cset() == (obj->forwardee() == obj)) failed: Only evac-failed objects must be in the collection set here but is not
• 96fef40: 8189591: No way to locally suppress doclint warnings
• 7fc3a8d: 8275149: (ch) ReadableByteChannel returned by Channels.newChannel(InputStream) throws ReadOnlyBufferException
• 831802d: 8275163: Deflater::deflate methods omit javadoc for ReadOnlyBufferException
• ad9e234: 8275145: file.encoding system property has an incorrect value on Windows
• ... and 158 more: https://git.openjdk.java.net/jdk/compare/0786d8b7b367e3aa3ffa54a3e339572938378dca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit a619f89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.