Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net #5826

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Oct 5, 2021

Augmentations to javac's Xlint:serial checking are out for review (#5709) and the sun.net classes in this PR would need some changes to pass under the expanded checks.

The changes are to suppress warnings where non-transient fields in serializable types are not declared with a type statically known to be serializable. That isn't necessarily a correctness issues, but it does merit further scrutiny.

The changes in the PR are consistent with similar changes made in JDK libraries under the umbrella issue JDK-8231641.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5826/head:pull/5826
$ git checkout pull/5826

Update a local copy of the PR:
$ git checkout pull/5826
$ git pull https://git.openjdk.java.net/jdk pull/5826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5826

View PR using the GUI difftool:
$ git pr show -t 5826

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5826.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 5, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label Oct 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 5, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 332f067: 8274729: Define Position.NOPOS == Diagnostic.NOPOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 5, 2021
@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Oct 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

Going to push as commit d34ec6c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 332f067: 8274729: Define Position.NOPOS == Diagnostic.NOPOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@jddarcy Pushed as commit d34ec6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8274793 branch Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net
2 participants