Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274621: NullPointerException because listenAddress[0] is null #5830

Closed
wants to merge 1 commit into from
Closed

8274621: NullPointerException because listenAddress[0] is null #5830

wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Oct 5, 2021

The change fixes ProcessTools.startProcess "warmup predicate" synchronization issue.
Initially the predicate was called only for STDOUT;
From jdk8 it's called for STDERR too (but ProcessTools javadoc was not updated).
The fix keeps existing functionality as is (as we have this behavior for a long time and we have tests which expect STDERR output), but adds synchronization to avoid calling predicate after previous call returned "true".
Also updated javadoc to reflect actual behavior.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274621: NullPointerException because listenAddress[0] is null

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5830/head:pull/5830
$ git checkout pull/5830

Update a local copy of the PR:
$ git checkout pull/5830
$ git pull https://git.openjdk.java.net/jdk pull/5830/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5830

View PR using the GUI difftool:
$ git pr show -t 5830

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5830.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 5, 2021

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Oct 5, 2021

/label add serviceability

@openjdk openjdk bot added rfr serviceability labels Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@alexmenkov
The serviceability label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 5, 2021

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Looks good.
Thanks,
Serguei

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274621: NullPointerException because listenAddress[0] is null

Reviewed-by: sspitsyn, lmesnik, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 347 new commits pushed to the master branch:

  • c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
  • 5a768f7: 8276054: JMH benchmarks for Fences
  • 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
  • 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
  • cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
  • c92f230: 8276110: Problemlist javax/swing/JMenu/4515762/bug4515762.java for macos12
  • 309acbf: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • abe52ae: 8275518: accessibility issue in Inet6Address docs
  • 85d8cd8: 8276100: Remove G1SegmentedArray constructor name parameter
  • a343fa8: 8275865: Print deoptimization statistics in product builds
  • ... and 337 more: https://git.openjdk.java.net/jdk/compare/7326481143c1321700cbf2caa9e068c5077e22c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 6, 2021
@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Oct 27, 2021

Ping.
Need 2nd reviewer

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Oct 29, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

Going to push as commit 5bbc8d3.
Since your change was applied there have been 366 commits pushed to the master branch:

  • 5021a12: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed
  • fe6a202: 8271356: Modify jdb to treat an empty command as a repeat of the previous command
  • cef9db9: 8276039: Remove unnecessary qualifications of java_lang_Class::
  • 13265f9: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976
  • 5facaa2: 8276128: (bf) Remove unused constant ARRAY_BASE_OFFSET from Direct-X-Buffer
  • d6d82f5: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
  • a1ec4f9: 6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7
  • 8cc5950: 8251468: X509Certificate.get{Subject,Issuer}AlternativeNames and getExtendedKeyUsage do not throw CertificateParsingException if extension is unparseable
  • 4c3491b: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac
  • c0cda1d: 8273026: Slow LoginContext.login() on multi threading application
  • ... and 356 more: https://git.openjdk.java.net/jdk/compare/7326481143c1321700cbf2caa9e068c5077e22c4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

@alexmenkov Pushed as commit 5bbc8d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the startProcessWarmup branch Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
4 participants