Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274407: (tz) Update Timezone Data to 2021c #5832

Closed
wants to merge 4 commits into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Oct 6, 2021

This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c level. Note that the tz data is "as is", as released by IANA. No merged links are retracted.
The PR also fixes two issues along with the 2021c upgrade.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5832/head:pull/5832
$ git checkout pull/5832

Update a local copy of the PR:
$ git checkout pull/5832
$ git pull https://git.openjdk.java.net/jdk pull/5832/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5832

View PR using the GUI difftool:
$ git pr show -t 5832

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5832.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 6, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build core-libs i18n labels Oct 6, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Oct 6, 2021

/issue add JDK-8274467, JDK-8274468

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@naotoj
Adding additional issue to issue list: 8274467: TestZoneInfo310.java fails with tzdata2021b.

Adding additional issue to issue list: 8274468: TimeZoneTest.java fails with tzdata2021b.

@naotoj naotoj marked this pull request as ready for review Oct 6, 2021
@openjdk openjdk bot added the rfr label Oct 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 6, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274407: (tz) Update Timezone Data to 2021c
8274467: TestZoneInfo310.java fails with tzdata2021b
8274468: TimeZoneTest.java fails with tzdata2021b

Reviewed-by: rriggs, iris, coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 9945f7a: 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management
  • 754bc82: 8274525: Replace uses of StringBuffer with StringBuilder in java.xml
  • 4e7d7ca: 8273711: Remove redundant stream() call before forEach in jdk.jlink
  • f3cedbe: 8274464: Remove redundant stream() call before forEach in java.* modules
  • c10de35: 8262944: Improve exception message when automatic module lists provider class not in JAR file
  • b8af6a9: 8273917: Remove 'leaf' ranking for Mutex
  • c80a612: 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm
  • 9759fcb: 8274496: Use String.contains() instead of String.indexOf() in java.desktop
  • cdf8930: 8274625: Search field placeholder behavior
  • df125f6: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/df7b0c707713195c93ff4e745c89155ee8e4c571...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 6, 2021
@coffeys
Copy link
Contributor

@coffeys coffeys commented Oct 6, 2021

pre-1970 data for some time zones is lost or becomes inaccurate with this tzdata release. Do we plan to release-note that point ?

coffeys
coffeys approved these changes Oct 6, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Oct 6, 2021

Good point, @coffeys. I'll make sure they are described in the release note.

@naotoj
Copy link
Member Author

@naotoj naotoj commented Oct 7, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

Going to push as commit 8ca0846.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 4ab274a: 8274858: Remove unused dictionary_classes_do functions
  • 03a8d34: 8273826: Correct Manifest file name and NPE checks
  • 722d639: 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows
  • 340c715: 8273929: Remove GzipRandomAccess in heap dump test
  • 8319836: 8274546: Shenandoah: Remove unused ShenandoahUpdateRootsTask copy
  • d5ccfa2: 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi
  • 29dcbb7: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
  • 5762ec2: 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes()
  • 4e960fe: 8274497: Unnecessary Vector usage in AquaFileSystemModel
  • c833b4d: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/df7b0c707713195c93ff4e745c89155ee8e4c571...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

@naotoj Pushed as commit 8ca0846.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build core-libs i18n integrated
4 participants