Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274851: [PPC64] Port zgc to linux on ppc64le #5842

Closed
wants to merge 6 commits into from

Conversation

Quaffel
Copy link
Member

@Quaffel Quaffel commented Oct 6, 2021

Port the Z garbage collector (JDK-8209683) to linux on ppc64le.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5842/head:pull/5842
$ git checkout pull/5842

Update a local copy of the PR:
$ git checkout pull/5842
$ git pull https://git.openjdk.java.net/jdk pull/5842/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5842

View PR using the GUI difftool:
$ git pr show -t 5842

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5842.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2021

👋 Welcome back nradomski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 6, 2021
@openjdk
Copy link

openjdk bot commented Oct 6, 2021

@Quaffel The following labels will be automatically applied to this pull request:

  • build
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build hotspot labels Oct 6, 2021
@Quaffel
Copy link
Member Author

Quaffel commented Oct 6, 2021

/label add hotspot-gc,zgc

@openjdk
Copy link

openjdk bot commented Oct 6, 2021

@Quaffel The label zgc is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@mlbridge
Copy link

mlbridge bot commented Oct 6, 2021

Webrevs

@Quaffel
Copy link
Member Author

Quaffel commented Oct 6, 2021

/label add hotspot-gc

@openjdk openjdk bot added the hotspot-gc label Oct 6, 2021
@openjdk
Copy link

openjdk bot commented Oct 6, 2021

@Quaffel
The hotspot-gc label was successfully added.

make/autoconf/jvm-features.m4 Outdated Show resolved Hide resolved
make/hotspot/gensrc/GensrcAdlc.gmk Outdated Show resolved Hide resolved
magicus
magicus approved these changes Oct 7, 2021
Copy link
Member

@magicus magicus left a comment

Build changes look good now. I leave it to others to determine the actual code changes.

@openjdk
Copy link

openjdk bot commented Oct 7, 2021

@Quaffel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274851: [PPC64] Port zgc to linux on ppc64le

Reviewed-by: ihse, pliden, mdoerr, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • cf82867: 8275049: [ZGC] missing null check in ZNMethod::log_register
  • ab34cce: 8275186: Suppress warnings on non-serializable array component types in xml
  • b1b8350: 8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode
  • 03c2b73: 8275128: Build hsdis using normal build system
  • 124f823: 8268764: Use Long.hashCode() instead of int-cast where applicable
  • 8657f77: 8271514: support JFR use of new ThreadsList::Iterator
  • b8bd259: 8271737: Only normalize the cached user.dir property once
  • 89999f7: 8275131: Exceptions after a touchpad gesture on macOS
  • 07b1f1c: 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6
  • f623460: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception"
  • ... and 70 more: https://git.openjdk.java.net/jdk/compare/cdf89304eafce58e66127d4e277f5fcaf07c9954...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus, @pliden, @TheRealMDoerr, @fisk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 7, 2021
Copy link
Contributor

@pliden pliden left a comment

Nice to see ZGC ported to linux/ppc!

I don't have a lot to say about the ppc-specific code. As you know, we at Oracle don't build and test on that platform, so any problems here will go unnoticed by us. It would be good to see a review or two from your colleagues at SAP.

src/hotspot/share/gc/z/zBarrierSetAssembler.cpp Outdated Show resolved Hide resolved
src/hotspot/share/gc/z/zBarrierSetAssembler.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Nice contribution! Thanks for doing the changes I had requested during my offline review. New version needs a few minor fixes, but looks great in general.

src/hotspot/cpu/ppc/ppc.ad Outdated Show resolved Hide resolved
src/hotspot/cpu/ppc/ppc.ad Outdated Show resolved Hide resolved
src/hotspot/cpu/ppc/ppc.ad Outdated Show resolved Hide resolved
fisk
fisk approved these changes Oct 8, 2021
Copy link
Contributor

@fisk fisk left a comment

Thank you for contributing a ZGC port to PPC. Apart from what has already been said, this looks good to me.

pliden
pliden approved these changes Oct 8, 2021
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Thanks for doing the requested fixes. LGTM.

@Quaffel
Copy link
Member Author

Quaffel commented Oct 11, 2021

Thank you for your reviews! Glad to see that the changes have been so well received.
/integrate

@openjdk openjdk bot added the sponsor label Oct 11, 2021
@openjdk
Copy link

openjdk bot commented Oct 11, 2021

@Quaffel
Your change (at version 052ad5c) is now ready to be sponsored by a Committer.

@Quaffel Quaffel changed the base branch from master to pr/5892 Oct 12, 2021
@openjdk openjdk bot removed sponsor ready labels Oct 12, 2021
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/5892 to master Oct 13, 2021
@openjdk-notifier
Copy link

openjdk-notifier bot commented Oct 13, 2021

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8275049_ZGC_log_register
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added sponsor ready labels Oct 13, 2021
@TheRealMDoerr
Copy link
Contributor

TheRealMDoerr commented Oct 13, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

Going to push as commit 337b73a.
Since your change was applied there have been 80 commits pushed to the master branch:

  • cf82867: 8275049: [ZGC] missing null check in ZNMethod::log_register
  • ab34cce: 8275186: Suppress warnings on non-serializable array component types in xml
  • b1b8350: 8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode
  • 03c2b73: 8275128: Build hsdis using normal build system
  • 124f823: 8268764: Use Long.hashCode() instead of int-cast where applicable
  • 8657f77: 8271514: support JFR use of new ThreadsList::Iterator
  • b8bd259: 8271737: Only normalize the cached user.dir property once
  • 89999f7: 8275131: Exceptions after a touchpad gesture on macOS
  • 07b1f1c: 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6
  • f623460: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception"
  • ... and 70 more: https://git.openjdk.java.net/jdk/compare/cdf89304eafce58e66127d4e277f5fcaf07c9954...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@TheRealMDoerr @Quaffel Pushed as commit 337b73a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Quaffel Quaffel deleted the feat/zgc-ppc64 branch Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build hotspot hotspot-gc integrated
5 participants