8274851: [PPC64] Port zgc to linux on ppc64le #5842

Quaffel · 2021-10-06T19:27:26Z

Port the Z garbage collector (JDK-8209683) to linux on ppc64le.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8274851: [ppc64] Port zgc to linux on ppc64le

Reviewers

Magnus Ihse Bursie (@magicus - Reviewer) ⚠️ Review applies to 5da8c1b
Per Liden (@pliden - Reviewer)
Martin Doerr (@TheRealMDoerr - Reviewer)
Erik Österlund (@fisk - Reviewer) ⚠️ Review applies to 5da8c1b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5842/head:pull/5842
$ git checkout pull/5842

Update a local copy of the PR:
$ git checkout pull/5842
$ git pull https://git.openjdk.java.net/jdk pull/5842/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5842

View PR using the GUI difftool:
$ git pr show -t 5842

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5842.diff

bridgekeeper · 2021-10-06T19:28:49Z

👋 Welcome back nradomski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-10-06T19:31:25Z

@Quaffel The following labels will be automatically applied to this pull request:

build
hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Quaffel · 2021-10-06T19:34:16Z

/label add hotspot-gc,zgc

openjdk · 2021-10-06T19:35:26Z

@Quaffel The label zgc is not a valid label. These labels are valid:

serviceability
hotspot
hotspot-compiler
ide-support
kulla
i18n
shenandoah
jdk
javadoc
security
hotspot-runtime
jmx
build
nio
client
core-libs
compiler
net
hotspot-gc
hotspot-jfr

mlbridge · 2021-10-06T19:38:31Z

Webrevs

Quaffel · 2021-10-06T19:59:49Z

/label add hotspot-gc

openjdk · 2021-10-06T20:00:14Z

@Quaffel
The hotspot-gc label was successfully added.

make/autoconf/jvm-features.m4

make/hotspot/gensrc/GensrcAdlc.gmk

magicus

Build changes look good now. I leave it to others to determine the actual code changes.

openjdk · 2021-10-07T12:13:04Z

@Quaffel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274851: [PPC64] Port zgc to linux on ppc64le

Reviewed-by: ihse, pliden, mdoerr, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

cf82867: 8275049: [ZGC] missing null check in ZNMethod::log_register
ab34cce: 8275186: Suppress warnings on non-serializable array component types in xml
b1b8350: 8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode
03c2b73: 8275128: Build hsdis using normal build system
124f823: 8268764: Use Long.hashCode() instead of int-cast where applicable
8657f77: 8271514: support JFR use of new ThreadsList::Iterator
b8bd259: 8271737: Only normalize the cached user.dir property once
89999f7: 8275131: Exceptions after a touchpad gesture on macOS
07b1f1c: 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6
f623460: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception"
... and 70 more: https://git.openjdk.java.net/jdk/compare/cdf89304eafce58e66127d4e277f5fcaf07c9954...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus, @pliden, @TheRealMDoerr, @fisk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

pliden

Nice to see ZGC ported to linux/ppc!

I don't have a lot to say about the ppc-specific code. As you know, we at Oracle don't build and test on that platform, so any problems here will go unnoticed by us. It would be good to see a review or two from your colleagues at SAP.

src/hotspot/share/gc/z/zBarrierSetAssembler.cpp

TheRealMDoerr

Nice contribution! Thanks for doing the changes I had requested during my offline review. New version needs a few minor fixes, but looks great in general.

src/hotspot/cpu/ppc/ppc.ad

fisk

Thank you for contributing a ZGC port to PPC. Apart from what has already been said, this looks good to me.

TheRealMDoerr

Thanks for doing the requested fixes. LGTM.

Quaffel · 2021-10-11T20:16:09Z

Thank you for your reviews! Glad to see that the changes have been so well received.
/integrate

openjdk · 2021-10-11T20:17:27Z

@Quaffel
Your change (at version 052ad5c) is now ready to be sponsored by a Committer.

openjdk-notifier · 2021-10-13T07:15:44Z

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8275049_ZGC_log_register
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

TheRealMDoerr · 2021-10-13T07:34:59Z

/sponsor

openjdk · 2021-10-13T07:36:59Z

Going to push as commit 337b73a.
Since your change was applied there have been 80 commits pushed to the master branch:

cf82867: 8275049: [ZGC] missing null check in ZNMethod::log_register
ab34cce: 8275186: Suppress warnings on non-serializable array component types in xml
b1b8350: 8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode
03c2b73: 8275128: Build hsdis using normal build system
124f823: 8268764: Use Long.hashCode() instead of int-cast where applicable
8657f77: 8271514: support JFR use of new ThreadsList::Iterator
b8bd259: 8271737: Only normalize the cached user.dir property once
89999f7: 8275131: Exceptions after a touchpad gesture on macOS
07b1f1c: 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6
f623460: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception"
... and 70 more: https://git.openjdk.java.net/jdk/compare/cdf89304eafce58e66127d4e277f5fcaf07c9954...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-10-13T07:37:18Z

@TheRealMDoerr @Quaffel Pushed as commit 337b73a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Port zgc to linux on ppc64le

17946dd

openjdk bot added the rfr Pull request is ready for review label Oct 6, 2021

openjdk bot added build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Oct 6, 2021

openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 6, 2021

magicus suggested changes Oct 7, 2021

View reviewed changes

make/autoconf/jvm-features.m4 Outdated Show resolved Hide resolved

make/hotspot/gensrc/GensrcAdlc.gmk Outdated Show resolved Hide resolved

Quaffel added 2 commits October 7, 2021 10:16

Remove copyright headers

43a9cc7

Update autoconf error message

5da8c1b

magicus approved these changes Oct 7, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2021

pliden suggested changes Oct 7, 2021

View reviewed changes

src/hotspot/share/gc/z/zBarrierSetAssembler.cpp Outdated Show resolved Hide resolved

src/hotspot/share/gc/z/zBarrierSetAssembler.cpp Outdated Show resolved Hide resolved

TheRealMDoerr suggested changes Oct 8, 2021

View reviewed changes

src/hotspot/cpu/ppc/ppc.ad Outdated Show resolved Hide resolved

src/hotspot/cpu/ppc/ppc.ad Outdated Show resolved Hide resolved

src/hotspot/cpu/ppc/ppc.ad Outdated Show resolved Hide resolved

fisk approved these changes Oct 8, 2021

View reviewed changes

Quaffel added 3 commits October 8, 2021 17:28

Add ByteSize constructor to Address

28bf447

Fix predicate conditions

eb9a9df

Remove superfluous copyright change

052ad5c

pliden approved these changes Oct 8, 2021

View reviewed changes

TheRealMDoerr approved these changes Oct 11, 2021

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2021

Quaffel changed the base branch from master to pr/5892 October 12, 2021 08:56

openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Oct 12, 2021

openjdk-notifier bot changed the base branch from pr/5892 to master October 13, 2021 07:15

openjdk bot added sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Oct 13, 2021

openjdk bot closed this Oct 13, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 13, 2021

Quaffel deleted the feat/zgc-ppc64 branch October 13, 2021 07:38

8274851: [PPC64] Port zgc to linux on ppc64le #5842

8274851: [PPC64] Port zgc to linux on ppc64le #5842

Quaffel commented Oct 6, 2021 •

edited by openjdk bot

bridgekeeper bot commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

Quaffel commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

mlbridge bot commented Oct 6, 2021 •

edited

Quaffel commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

magicus left a comment

openjdk bot commented Oct 7, 2021 •

edited

pliden left a comment

TheRealMDoerr left a comment

fisk left a comment

TheRealMDoerr left a comment

Quaffel commented Oct 11, 2021

openjdk bot commented Oct 11, 2021

openjdk-notifier bot commented Oct 13, 2021

TheRealMDoerr commented Oct 13, 2021

openjdk bot commented Oct 13, 2021

openjdk bot commented Oct 13, 2021

8274851: [PPC64] Port zgc to linux on ppc64le #5842

8274851: [PPC64] Port zgc to linux on ppc64le #5842

Conversation

Quaffel commented Oct 6, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

Quaffel commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

mlbridge bot commented Oct 6, 2021 • edited

Webrevs

Quaffel commented Oct 6, 2021

openjdk bot commented Oct 6, 2021

magicus left a comment

Choose a reason for hiding this comment

openjdk bot commented Oct 7, 2021 • edited

pliden left a comment

Choose a reason for hiding this comment

TheRealMDoerr left a comment

Choose a reason for hiding this comment

fisk left a comment

Choose a reason for hiding this comment

TheRealMDoerr left a comment

Choose a reason for hiding this comment

Quaffel commented Oct 11, 2021

openjdk bot commented Oct 11, 2021

openjdk-notifier bot commented Oct 13, 2021

TheRealMDoerr commented Oct 13, 2021

openjdk bot commented Oct 13, 2021

openjdk bot commented Oct 13, 2021

Quaffel commented Oct 6, 2021 •

edited by openjdk bot

mlbridge bot commented Oct 6, 2021 •

edited

openjdk bot commented Oct 7, 2021 •

edited