8274858: Remove unused dictionary_classes_do functions

[coleenp]

These were needed once by JVMTI to find classes that have been initiated by a class loader and not just defined, but that code was changed. Other callers have been removed. The remaining use doesn't need initiated classes for initializing itables, so doesn't need to walk the dictionary only the ClassLoaderData as the defining class loader.

In this place, only the bootstrap loader is loaded, so the CLDG walk is overkill but this is only for !UseSharedSpaces so harmless and prevents making functions public.

Tested with tier1-3

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274858: Remove unused dictionary_classes_do functions

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Harold Seigel (@hseigel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5843/head:pull/5843
$ git checkout pull/5843

Update a local copy of the PR:
$ git checkout pull/5843
$ git pull https://git.openjdk.java.net/jdk pull/5843/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5843

View PR using the GUI difftool:
$ git pr show -t 5843

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5843.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3002960f)

[dholmes-ora]

Hi Coleen,

This seems fine.

Thanks,
David

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274858: Remove unused dictionary_classes_do functions

Reviewed-by: dholmes, hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 03a8d34: 8273826: Correct Manifest file name and NPE checks
• 722d639: 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows
• 340c715: 8273929: Remove GzipRandomAccess in heap dump test
• 8319836: 8274546: Shenandoah: Remove unused ShenandoahUpdateRootsTask copy
• d5ccfa2: 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi
• 29dcbb7: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
• 5762ec2: 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes()
• 4e960fe: 8274497: Unnecessary Vector usage in AquaFileSystemModel
• c833b4d: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern
• d57fb6f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/c10de3538b47c182d7bfeb02f348fac9b2ad0641...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hseigel]

Looks good!
Thanks, Harold

[coleenp]

Thanks David and Harold!
/integrate

[openjdk]

Going to push as commit 4ab274a.
Since your change was applied there have been 16 commits pushed to the master branch:

• 03a8d34: 8273826: Correct Manifest file name and NPE checks
• 722d639: 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows
• 340c715: 8273929: Remove GzipRandomAccess in heap dump test
• 8319836: 8274546: Shenandoah: Remove unused ShenandoahUpdateRootsTask copy
• d5ccfa2: 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi
• 29dcbb7: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
• 5762ec2: 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes()
• 4e960fe: 8274497: Unnecessary Vector usage in AquaFileSystemModel
• c833b4d: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern
• d57fb6f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/c10de3538b47c182d7bfeb02f348fac9b2ad0641...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 4ab274a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.