Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop #5847

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Oct 7, 2021

Pass cause exception as constructor parameter is shorter and easier to read.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5847/head:pull/5847
$ git checkout pull/5847

Update a local copy of the PR:
$ git checkout pull/5847
$ git pull https://git.openjdk.java.net/jdk pull/5847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5847

View PR using the GUI difftool:
$ git pr show -t 5847

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5847.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 7, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Oct 7, 2021
@mrserb
Copy link
Member

@mrserb mrserb commented Oct 7, 2021

Looks fine.

@turbanoff turbanoff changed the title [PATCH] Cleanup unnecessary calls to Throwable.initCause() in java.desktop 8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop Oct 8, 2021
@openjdk openjdk bot added the rfr label Oct 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 8, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop

Reviewed-by: jdv, serb, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • 75f5145: 8274925: Shenandoah: shenandoah/TestAllocHumongousFragment.java test failed on lock rank check
  • 83c3771: 8273881: Metaspace: test repeated deallocations
  • 3f01d03: 8275021: Test serviceability/sa/TestJmapCore.java fails with: java.io.IOException: Stack frame 0x4 not found
  • 3f07337: 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests
  • 0d80f6c: 8274379: Allow process of unsafe access errors in check_special_condition_for_native_trans
  • b870468: 8274347: Passing a nested switch expression as a parameter causes an NPE during compile
  • 110e38d: 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes
  • b7af890: 8274430: Remove some debug error printing code added in JDK-8017163
  • aaf2401: 8274927: Remove unnecessary G1ArchiveAllocator code
  • c55dd36: 8275008: gtest build failure due to stringop-overflow warning with gcc11
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/d5ccfa2ae965a9ae0f3597b0b90d702a3e0ea558...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jayathirthrao, @mrserb, @pankaj-bansal) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 8, 2021
mrserb
mrserb approved these changes Oct 8, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 11, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@turbanoff
Your change (at version 6820e58) is now ready to be sponsored by a Committer.

@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Oct 11, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

Going to push as commit 829dea4.
Since your change was applied there have been 40 commits pushed to the master branch:

  • 75f5145: 8274925: Shenandoah: shenandoah/TestAllocHumongousFragment.java test failed on lock rank check
  • 83c3771: 8273881: Metaspace: test repeated deallocations
  • 3f01d03: 8275021: Test serviceability/sa/TestJmapCore.java fails with: java.io.IOException: Stack frame 0x4 not found
  • 3f07337: 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests
  • 0d80f6c: 8274379: Allow process of unsafe access errors in check_special_condition_for_native_trans
  • b870468: 8274347: Passing a nested switch expression as a parameter causes an NPE during compile
  • 110e38d: 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes
  • b7af890: 8274430: Remove some debug error printing code added in JDK-8017163
  • aaf2401: 8274927: Remove unnecessary G1ArchiveAllocator code
  • c55dd36: 8275008: gtest build failure due to stringop-overflow warning with gcc11
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/d5ccfa2ae965a9ae0f3597b0b90d702a3e0ea558...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@pankaj-bansal @turbanoff Pushed as commit 829dea4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the unnecessary_Throwable.initCause_in_java.desktop branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
4 participants