8274903: Zero: Support AsyncGetCallTrace

[shipilev]

This is a Zero infrastructure improvement that makes Zero VM work with AsyncGetCallTrace, and by extension, async-profiler.

Zero is quite odd in stack management. The "real" stack actually contains the C++ Interpreter and the rest of VM code. The Java stack is reported through the usual "frame" mechanism the rest of VM uses to get the mapping from Template Interpreter, stub, and compiled code. So, to support Java-centric AsyncGetCallTrace, we t "only" need Zero to report the proper Java frames from its ZeroStack from the profiling/signal handlers.

Additional testing:

• Linux x86_64 Zero serviceability/AsyncGetCallTrace now pass
• Linux x86_64 Zero works with async-profiler

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274903: Zero: Support AsyncGetCallTrace

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5848/head:pull/5848
$ git checkout pull/5848

Update a local copy of the PR:
$ git checkout pull/5848
$ git pull https://git.openjdk.java.net/jdk pull/5848/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5848

View PR using the GUI difftool:
$ git pr show -t 5848

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5848.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (373f15ae)
• 03: Full - Incremental (bc4ba33b)
• 02: Full - Incremental (68ef4b63)
• 01: Full - Incremental (8e25258d)
• 00: Full (5575516c)

[bridgekeeper]

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[shipilev]

Anyone has opinions about this patch? :)

[sspitsyn]

Hi Aleksey,
Thank you for the update. It looks pretty good to me.
I've inlined a couple of minor comments.
Also, I hope, you will update the copyright years.
Thanks,
Serguei

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274903: Zero: Support AsyncGetCallTrace

Reviewed-by: sspitsyn, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 181 new commits pushed to the master branch:

• fd8cb2d: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
• e5cb84e: 8278336: Use int64_t to represent byte quantities consistently in JfrObjectAllocationSample
• 54993b1: 8278309: [windows] use of uninitialized OSThread::_state
• 10e0318: 8278158: jwebserver should set request timeout
• 5dcdee4: 8262341: Refine identical code in AddI/LNode.
• b334d96: 8276964: Better indicate a snippet that could not be processed
• 30f0c64: 8277992: Add fast jdk_svc subtests to jdk:tier3
• 5266e7d: 8278379: Zero VM is broken due to UseRTMForStackLocks was not declared after JDK-8276901
• e7db581: 8277168: AArch64: Enable arraycopy partial inlining with SVE
• fb6d611: 8278276: G1: Refine naming of G1GCParPhaseTimesTracker::_must_record
• ... and 171 more: https://git.openjdk.java.net/jdk/compare/c3a7f2f4bce9170c1630e01eebd4fcd174b44964...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thank you, @sspitsyn! Any more reviews, anyone?

[shipilev]

Thank you, @sspitsyn! Any more reviews, anyone?

No other reviews? I'd like to integrate this soon.

[shipilev]

Thank you!

/integrate

[openjdk]

Going to push as commit 92aa75b.
Since your change was applied there have been 190 commits pushed to the master branch:

• 8345453: 8272392: Lanai: SwingSet2. Black background on expanding tree node
• 9b74749: 8276660: Scalability bottleneck in java.security.Provider.getService()
• 2478158: 8277361: java/nio/channels/Channels/ReadXBytes.java fails with OOM error
• 8af3b27: 8277850: C2: optimize mask checks in counted loops
• 3e93e0b: 8276769: -Xshare:auto should tolerate problems in the CDS archive
• 79165b7: 8278324: Update the --generate-cds-archive jlink plugin usage message
• 40d726b: 8278310: Improve logging in CDS DynamicLoaderConstraintsTest.java
• e4852c6: 8277998: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#custom-cl-zgc failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
• 37921e3: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
• fd8cb2d: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
• ... and 180 more: https://git.openjdk.java.net/jdk/compare/c3a7f2f4bce9170c1630e01eebd4fcd174b44964...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 92aa75b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.