Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233749: Files.exists javadoc doesn't mention eating IOException #5856

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Oct 7, 2021

Add @see FileSystemProvider#checkAccess link per the suggestion in the issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8233749: Files.exists javadoc doesn't mention eating IOException

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5856/head:pull/5856
$ git checkout pull/5856

Update a local copy of the PR:
$ git checkout pull/5856
$ git pull https://git.openjdk.java.net/jdk pull/5856/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5856

View PR using the GUI difftool:
$ git pr show -t 5856

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5856.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@bplb
Copy link
Member Author

bplb commented Oct 7, 2021

A CSR is not required for this small change.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2021
@openjdk
Copy link

openjdk bot commented Oct 7, 2021

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Oct 7, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 7, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8233749: Files.exists javadoc doesn't mention eating IOException

Reviewed-by: lancea, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

  • 8de7763: 8273152: Refactor CDS FileMapHeader loading code
  • 920e707: 8274920: ProblemList 2 VectorAPI tests failing due to "assert(!vbox->is_Phi()) failed"
  • 7de2cf8: 8273910: Redundant condition and assignment in java.net.URI
  • 8ca0846: 8274407: (tz) Update Timezone Data to 2021c
  • 4ab274a: 8274858: Remove unused dictionary_classes_do functions
  • 03a8d34: 8273826: Correct Manifest file name and NPE checks
  • 722d639: 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows
  • 340c715: 8273929: Remove GzipRandomAccess in heap dump test
  • 8319836: 8274546: Shenandoah: Remove unused ShenandoahUpdateRootsTask copy
  • d5ccfa2: 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi
  • ... and 35 more: https://git.openjdk.java.net/jdk/compare/bb0bab57a1ff447bfb41cfe10c91838a6812b93d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2021
Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to change the JBS description to make it clear that this is just adding a link rather than changing the description.

@bplb
Copy link
Member Author

bplb commented Oct 8, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 8, 2021

Going to push as commit 239a35a.
Since your change was applied there have been 52 commits pushed to the master branch:

  • ec19907: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile
  • ccbce10: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop
  • 36b89a1: 8274785: ciReplay: Potential crash due to uninitialized Compile::_ilt variable
  • 2aacd42: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition
  • 6364719: 8274004: Change 'nonleaf' rank name
  • b60837a: 8272586: emit abstract machine code in hs-err logs
  • 97ea9dd: 8274840: Update OS detection code to recognize Windows 11
  • 8de7763: 8273152: Refactor CDS FileMapHeader loading code
  • 920e707: 8274920: ProblemList 2 VectorAPI tests failing due to "assert(!vbox->is_Phi()) failed"
  • 7de2cf8: 8273910: Redundant condition and assignment in java.net.URI
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/bb0bab57a1ff447bfb41cfe10c91838a6812b93d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 8, 2021
@openjdk
Copy link

openjdk bot commented Oct 8, 2021

@bplb Pushed as commit 239a35a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the Files-exists-8233749 branch October 8, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
3 participants