JDK-8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string

[alexmenkov]

The fix adds "-XX:PerfMaxStringConstLength" argument running target app (default is 1024, 8K should be enough for any environments)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5858/head:pull/5858
$ git checkout pull/5858

Update a local copy of the PR:
$ git checkout pull/5858
$ git pull https://git.openjdk.java.net/jdk pull/5858/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5858

View PR using the GUI difftool:
$ git pr show -t 5858

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5858.diff

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following labels will be automatically applied to this pull request:

• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e3af79d4)

[sspitsyn]

LGTM.
Thanks,
Serguei

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string

Reviewed-by: sspitsyn, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 379 new commits pushed to the master branch:

• 9771544: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
• e265f83: 8276107: Preventive collections trigger before maxing out heap
• c8abe35: 8276121: G1: Remove unused and uninitialized _g1h in g1SATBMarkQueueSet.hpp
• f55e68c: 8275950: Use only _thread_in_vm in ~ThreadBlockInVMPreprocess()
• 4ac8403: 8276218: JFR: Clean up jdk.jfr.dcmd
• 89ade1d: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
• dbf5100: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
• 5bb1992: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
• 158831e: 8274320: os::fork_and_exec() should be using posix_spawn
• bf2e9ee: 8275080: G1CollectedHeap::expand() returns the wrong value
• ... and 369 more: https://git.openjdk.java.net/jdk/compare/7326481143c1321700cbf2caa9e068c5077e22c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexmenkov]

Ping.
Need 2nd reviewer

[plummercj]

Actually revoking my review for the moment. Do we have any tests that currently test the default PerfMaxStringConstLength, and this change could be subverting the test by making it so the length is never exceeded?

[AlanBateman]

/label remove core-libs

[openjdk]

@AlanBateman
The core-libs label was successfully removed.

[alexmenkov]

Actually revoking my review for the moment. Do we have any tests that currently test the default PerfMaxStringConstLength, and this change could be subverting the test by making it so the length is never exceeded?

We don't have any test for PerfMaxStringConstLength.
I think we can fix the issue by using LingeredApp.startAppExactJvmOpts instead of LingeredApp.startApp.
I the case test VM options are not added to target app and command line contains only specified options.
It should be ok as we test only jps functionality.
I don't have strong opinion which way is better.

[plummercj]

Ok. You can proceed with your current fix if you'd like.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit bb92fb0.
Since your change was applied there have been 397 commits pushed to the master branch:

• 6a04899: 8275840: Add test to java/nio/channels/Channels/TransferTo.java to test transfer sizes > 2GB
• 01105d6: 8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java
• 8fc16f1: 8275729: Qualified method names in CodeHeap Analytics
• fa4ce82: 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win)
• 495c828: 8276188: Clarify "default charset" descriptions in String class
• cd778f5: 8202667: java/awt/Debug/DumpOnKey/DumpOnKey.java times out on Windows
• b889f2a: 8276175: codestrings.validate_vm gtest still broken on ppc64 after JDK-8276046
• 5b4e398: 8275766: (tz) Update Timezone Data to 2021e
• 8630f55: 8275406: Add copy-to-clipboard feature to snippet UI
• 9971a2c: 8275735: [linux] Remove deprecated Metrics api (kernel memory limit)
• ... and 387 more: https://git.openjdk.java.net/jdk/compare/7326481143c1321700cbf2caa9e068c5077e22c4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit bb92fb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.