8274934: Attempting to acquire lock JNICritical_lock/41 out of order with lock MultiArray_lock/41

[coleenp]

Fixed the lock ranking so that JNICritical_lock is MultiArray_lock-1.
Tested where there were observed failures:
tier1,tier2,tier3 -b linux-x64-debug,linux-x64,windows-x64-debug
tier5 -b linux-aarch64-debug
tier4 -b linux-x64-debug

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274934: Attempting to acquire lock JNICritical_lock/41 out of order with lock MultiArray_lock/41

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5869/head:pull/5869
$ git checkout pull/5869

Update a local copy of the PR:
$ git checkout pull/5869
$ git pull https://git.openjdk.java.net/jdk pull/5869/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5869

View PR using the GUI difftool:
$ git pr show -t 5869

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5869.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dcubed-ojdk]

Thumbs up.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274934: Attempting to acquire lock JNICritical_lock/41 out of order with lock MultiArray_lock/41

Reviewed-by: dcubed, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 239a35a: 8233749: Files.exists javadoc doesn't mention eating IOException
• ec19907: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile
• ccbce10: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop
• 36b89a1: 8274785: ciReplay: Potential crash due to uninitialized Compile::_ilt variable
• 2aacd42: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (d513f8d7)

[iklam]

LGTM

[coleenp]

Thanks for the reviews Dan and Ioi. I'm going to push this as a trivial change to prevent failures over the weekend.
/integrate

[openjdk]

Going to push as commit 3cb9724.
Since your change was applied there have been 5 commits pushed to the master branch:

• 239a35a: 8233749: Files.exists javadoc doesn't mention eating IOException
• ec19907: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile
• ccbce10: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop
• 36b89a1: 8274785: ciReplay: Potential crash due to uninitialized Compile::_ilt variable
• 2aacd42: 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 3cb9724.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.