Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254349: The TestNoScreenMenuBar test should be updated #587

Closed
wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 10, 2020

This test tries to run an external application to make itself non-active and then sets and checks the global menu.

But it has a few issues:

  • As an external app, the "System Settings" app is used, but it looks like in macOS Catalina this app was moved, and nothing actually starts
  • The external app is closed via osascript which required special permission, and it is requested via a modal dialog if not granted already
  • It looks like the attempt to close(already closed app, since the open step failed) the "System Settings" via osascript actually activates it instead

So to prevent one more permission, and usage of some external app I just use the same java test as an external app but in a separate process. I have checked that the test fails if the fix for JDK-8146310 is removed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build (1/5 failed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) (1/9 failed) ✔️ (9/9 passed)

Failed test tasks

Issue

  • JDK-8254349: The TestNoScreenMenuBar test should be updated

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/587/head:pull/587
$ git checkout pull/587

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 10, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb marked this pull request as ready for review Oct 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 10, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added awt rfr labels Oct 10, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 10, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254349: The TestNoScreenMenuBar test should be updated

Reviewed-by: pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

  • 402d01a: 8254795: Remove obsolete template files
  • 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
  • 0570cc1: 8254855: Clean up and remove unused code in vmIntrinsics
  • 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
  • 34583eb: 8254161: Prevent instantiation of EnumSet subclasses through deserialization
  • 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
  • 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
  • 5145bed: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows
  • bdda205: 8254369: Node::disconnect_inputs may skip precedences
  • 96bb6e7: 8251325: Miss 'L' for long value in if statement
  • ... and 82 more: https://git.openjdk.java.net/jdk/compare/4b5ac3abacee0a4b06a9ed0ea57377ff903a90c3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 16, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Oct 16, 2020

/integrate

@openjdk openjdk bot closed this Oct 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@mrserb Since your change was applied there have been 92 commits pushed to the master branch:

  • 402d01a: 8254795: Remove obsolete template files
  • 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
  • 0570cc1: 8254855: Clean up and remove unused code in vmIntrinsics
  • 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
  • 34583eb: 8254161: Prevent instantiation of EnumSet subclasses through deserialization
  • 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
  • 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
  • 5145bed: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows
  • bdda205: 8254369: Node::disconnect_inputs may skip precedences
  • 96bb6e7: 8251325: Miss 'L' for long value in if statement
  • ... and 82 more: https://git.openjdk.java.net/jdk/compare/4b5ac3abacee0a4b06a9ed0ea57377ff903a90c3...master

Your commit was automatically rebased without conflicts.

Pushed as commit e66c6bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb:JDK-8254349 branch Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants