Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275003: Suppress warnings on non-serializable non-transient instance fields in windows mscapi #5879

Closed
wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Oct 9, 2021

Analogous to other recent cleanups like JDK-8274393, suppress warnings for serialization-related issues in the windows mscapi code.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275003: Suppress warnings on non-serializable non-transient instance fields in windows mscapi

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5879/head:pull/5879
$ git checkout pull/5879

Update a local copy of the PR:
$ git checkout pull/5879
$ git pull https://git.openjdk.java.net/jdk pull/5879/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5879

View PR using the GUI difftool:
$ git pr show -t 5879

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5879.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 9, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Oct 9, 2021
@openjdk openjdk bot added the rfr label Oct 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 9, 2021

Webrevs

Copy link

@valeriepeng valeriepeng left a comment

Looks fine. Thanks!

@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Oct 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275003: Suppress warnings on non-serializable non-transient instance fields in windows mscapi

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the master branch:

  • 895e2bd: 8274160: java/awt/Window/ShapedAndTranslucentWindows/Common.java delay is too high
  • fd10f19: 8275302: unexpected compiler error: cast, intersection types and sealed
  • 99bf7dd: 8275517: Off-by-one error in allocation
  • 8a3e0a1: 7008363: TEST_BUG: test/java/lang/StringCoding/CheckEncodings.sh does nothing and is very slow at that
  • a579483: 8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent
  • 002c538: 8275287: Relax memory ordering constraints on updating instance class and array class counters
  • 98ab4b0: 8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
  • dcd6e0d: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline
  • d17d81a: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator
  • a4491f2: 8275413: Remove unused InstanceKlass::set_array_klasses() method
  • ... and 108 more: https://git.openjdk.java.net/jdk/compare/8de77634c414cc348a6eb7b28fd6339befdb12d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

Going to push as commit 926966b.
Since your change was applied there have been 149 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@jddarcy Pushed as commit 926966b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8275003 branch Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants