Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254351: Minimal VM build fails with undeclared identifier 'MaxVectorSize' after JDK-8252847 #588

Closed
wants to merge 2 commits into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 10, 2020

To fix the bug, #if COMPILER2_OR_JVMCI was added.
Please review it. Thanks.

Testing:

  • Minimal and server-fastdebug builds on x86

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254351: Minimal VM build fails with undeclared identifier 'MaxVectorSize' after JDK-8252847

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/588/head:pull/588
$ git checkout pull/588

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2020

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@DamonFool
Copy link
Member Author

/issue add JDK-8254351
/test

/label add hotspot-compiler
/cc hotspot-compiler

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2020
@openjdk
Copy link

openjdk bot commented Oct 10, 2020

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 10, 2020
@openjdk
Copy link

openjdk bot commented Oct 10, 2020

@DamonFool
The hotspot-compiler label was successfully added.

@openjdk
Copy link

openjdk bot commented Oct 10, 2020

@DamonFool The hotspot-compiler label was already applied.

@mlbridge
Copy link

mlbridge bot commented Oct 10, 2020

Webrevs

@DamonFool
Copy link
Member Author

/test

@openjdk
Copy link

openjdk bot commented Oct 10, 2020

@DamonFool you need to get approval to run the tests in tier1 for commits up until 4bb6e2a

@openjdk openjdk bot added the test-request label Oct 10, 2020
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is good and trivial.

@openjdk
Copy link

openjdk bot commented Oct 11, 2020

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254351: Minimal VM build fails with undeclared identifier 'MaxVectorSize' after JDK-8252847

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cc52358: 8254335: logging/logStream.hpp includes memory/resourceArea.hpp but doesn't need it

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2020
@DamonFool
Copy link
Member Author

Thanks @vnkozlov for your review.
/integrate

@openjdk openjdk bot closed this Oct 11, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2020
@openjdk
Copy link

openjdk bot commented Oct 11, 2020

@DamonFool Since your change was applied there has been 1 commit pushed to the master branch:

  • cc52358: 8254335: logging/logStream.hpp includes memory/resourceArea.hpp but doesn't need it

Your commit was automatically rebased without conflicts.

Pushed as commit d43f141.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8254351 branch October 11, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated test-request
2 participants