New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8254351: Minimal VM build fails with undeclared identifier 'MaxVectorSize' after JDK-8252847 #588
Conversation
…Size' after JDK-8252847
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
/issue add JDK-8254351 /label add hotspot-compiler |
@DamonFool This issue is referenced in the PR title - it will now be updated. |
@DamonFool |
@DamonFool The |
Webrevs
|
/test |
@DamonFool you need to get approval to run the tests in tier1 for commits up until 4bb6e2a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix is good and trivial.
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks @vnkozlov for your review. |
@DamonFool Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit d43f141. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
To fix the bug, #if COMPILER2_OR_JVMCI was added.
Please review it. Thanks.
Testing:
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/588/head:pull/588
$ git checkout pull/588