8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations

[pconcannon]

Hi,

Could someone please review my changes (and CSR) to drop support for pre JDK 1.4 DatagramSocketImpl implementations?

These changes propose to drop support for DatagramSocketImpls that were compiled with JDK 1.3 or older, which do not have support for connected sockets, for peeking at received datagrams, and for joining and leaving a group at a specific interface. This support is legacy, and should be relatively safe to remove as such implementations do not compile with JDK 1.4 or newer.

Finally, with this set of proposed changes, if you have an oldImpl, and don’t use connect, then the methods joinGroup and leaveGroup will throw NoSuchMethodError. However, the current behaviour in DatagramSocketImpl is to throw an UnsupportedOperationsException for a method not implemented. Should this set of changes update the joinGroup and leaveGroup methods in order to preserve this behaviour?

CSR: https://bugs.openjdk.java.net/browse/JDK-8274633

Kind regards,

Patrick

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations

Reviewers

• Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 67265bd
• Daniel Fuchs (@dfuch - Reviewer) ⚠️ Review applies to 67265bd
• Vyom Tewari (@vyommani - Committer) ⚠️ Review applies to 0a920f6

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5887/head:pull/5887
$ git checkout pull/5887

Update a local copy of the PR:
$ git checkout pull/5887
$ git pull https://git.openjdk.java.net/jdk pull/5887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5887

View PR using the GUI difftool:
$ git pr show -t 5887

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5887.diff

[bridgekeeper]

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pconcannon The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (61d1c8ea)
• 02: Full - Incremental (0a920f65)
• 01: Full - Incremental (67265bd4)
• 00: Full (e17a8d98)

[AlanBateman]

The spec and implementation change look good. I don't have time to study the test right but I see Daniel is looking at it.

[openjdk]

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations

Reviewed-by: alanb, dfuchs, vtewari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[pconcannon]

/csr needed

[openjdk]

@pconcannon this pull request will not be integrated until the CSR request JDK-8274633 for issue JDK-8260428 has been approved.

[pconcannon]

/integrate

[openjdk]

Going to push as commit 9771544.
Since your change was applied there have been 6 commits pushed to the master branch:

• e265f83: 8276107: Preventive collections trigger before maxing out heap
• c8abe35: 8276121: G1: Remove unused and uninitialized _g1h in g1SATBMarkQueueSet.hpp
• f55e68c: 8275950: Use only _thread_in_vm in ~ThreadBlockInVMPreprocess()
• 4ac8403: 8276218: JFR: Clean up jdk.jfr.dcmd
• 89ade1d: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
• dbf5100: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point

Your commit was automatically rebased without conflicts.

[openjdk]

@pconcannon Pushed as commit 9771544.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.