Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks #5894

Closed
wants to merge 1 commit into from

Conversation

theRealAph
Copy link
Contributor

@theRealAph theRealAph commented Oct 11, 2021

This is more of the fallout from JDK-8273297.
We've noticed that blocks of less than 8kbytes are very slowly encrypted with AES/GCM . This is because of incorrect flag handline in vm_version_bsd_aarch64.cpp.

Before this patch:

Benchmark            (dataSize)  (keyLength)  (provider)  Mode  Cnt      Score      Error  Units
AESGCMBench.decrypt        8191          256              avgt    6  95821.232 ± 2447.246  ns/op
AESGCMBench.decrypt        8192          256              avgt    6   3653.619 ±   83.432  ns/op

After:

Benchmark            (dataSize)  (keyLength)  (provider)  Mode  Cnt     Score    Error  Units
AESGCMBench.decrypt        8191          256              avgt    6  3371.735 ± 70.204  ns/op
AESGCMBench.decrypt        8192          256              avgt    6  3119.928 ± 80.375  ns/op

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5894/head:pull/5894
$ git checkout pull/5894

Update a local copy of the PR:
$ git checkout pull/5894
$ git pull https://git.openjdk.java.net/jdk pull/5894/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5894

View PR using the GUI difftool:
$ git pr show -t 5894

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5894.diff

@theRealAph theRealAph changed the title Fix flag handling for MacOS. AArch64: Fix flag handling for MacOS. Oct 11, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 11, 2021

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@theRealAph The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Oct 11, 2021
@theRealAph theRealAph changed the title AArch64: Fix flag handling for MacOS. 8275052: AArch64: Fix flag handling for MacOS. Oct 13, 2021
@openjdk openjdk bot added the rfr label Oct 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 13, 2021

Webrevs

adinn
adinn approved these changes Oct 13, 2021
Copy link
Contributor

@adinn adinn left a comment

yes, looks ok.

@theRealAph
Copy link
Contributor Author

@theRealAph theRealAph commented Oct 13, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2021

@theRealAph This pull request has not yet been marked as ready for integration.

@theRealAph theRealAph changed the title 8275052: AArch64: Fix flag handling for MacOS. 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks Oct 28, 2021
@theRealAph
Copy link
Contributor Author

@theRealAph theRealAph commented Oct 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@theRealAph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks

Reviewed-by: ngasson, adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 233 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

Going to push as commit cb989cf.
Since your change was applied there have been 233 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@theRealAph Pushed as commit cb989cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
3 participants