Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275074: Cleanup unused code in JFR LeakProfiler #5899

Closed
wants to merge 1 commit into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Oct 11, 2021

While doing some fixes for Lilliput in JFR I noticed a couple of unused code paths. Let's remove them.
Specifically, it's the entirety of saveRestore.hpp/cpp and a helper method in edgeUtils.hpp/cpp.

Testing:

  • tier1
  • jdk/jfr

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5899/head:pull/5899
$ git checkout pull/5899

Update a local copy of the PR:
$ git checkout pull/5899
$ git pull https://git.openjdk.java.net/jdk pull/5899/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5899

View PR using the GUI difftool:
$ git pr show -t 5899

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5899.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 11, 2021

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@rkennke The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label Oct 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 11, 2021

Webrevs

Copy link

@mgronlun mgronlun left a comment

Looks good, thanks for noticing.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275074: Cleanup unused code in JFR LeakProfiler

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 829dea4: 8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop
  • 75f5145: 8274925: Shenandoah: shenandoah/TestAllocHumongousFragment.java test failed on lock rank check

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 11, 2021
@rkennke
Copy link
Contributor Author

@rkennke rkennke commented Oct 12, 2021

Looks good, thanks for noticing.

Thanks!
I am unsure whether or not JFR code / this particular change requires two reviews (as Hotspot in general) or if I can go ahead and integrate the PR. Please let me know!

@mgronlun
Copy link

@mgronlun mgronlun commented Oct 12, 2021

We are so few working on JFR, so we have decided that one Reviewer is ok - please go ahead.

For specific changes, it makes sense to enlist more R(r)eviwers, but for most, one Reviewer is considered ok.

@rkennke
Copy link
Contributor Author

@rkennke rkennke commented Oct 12, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

Going to push as commit e393c5e.
Since your change was applied there have been 14 commits pushed to the master branch:

  • e16b93a: 8274770: [PPC64] resolve_jobject needs a generic implementation to support load barriers
  • 1ab6414: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag
  • b460d6d: 8275091: /src/jdk.management.jfr/share/classes/module-info.java has non-canonical order
  • d04d4ee: 8274894: Use Optional.empty() instead of ofNullable(null) in HttpResponse.BodySubscribers.discarding
  • 33050f8: 8274986: max code printed in hs-err logs should be configurable
  • 8de2636: 8274615: Support relaxed atomic add for linux-aarch64
  • 7d2633f: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE
  • cfe7471: 8177814: jdk/editpad is not in jdk TEST.groups
  • a5f09d1: 8275031: runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present
  • ef0922e: 8274560: JFR: Add test for OldObjectSample event when using Shenandoah
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/83c37719290039672cf261701028c8eb044a2e77...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@rkennke Pushed as commit e393c5e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr integrated
2 participants