-
Notifications
You must be signed in to change notification settings - Fork 6k
8275074: Cleanup unused code in JFR LeakProfiler #5899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for noticing.
@rkennke This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks! |
We are so few working on JFR, so we have decided that one Reviewer is ok - please go ahead. For specific changes, it makes sense to enlist more R(r)eviwers, but for most, one Reviewer is considered ok. |
/integrate |
Going to push as commit e393c5e.
Your commit was automatically rebased without conflicts. |
While doing some fixes for Lilliput in JFR I noticed a couple of unused code paths. Let's remove them.
Specifically, it's the entirety of saveRestore.hpp/cpp and a helper method in edgeUtils.hpp/cpp.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5899/head:pull/5899
$ git checkout pull/5899
Update a local copy of the PR:
$ git checkout pull/5899
$ git pull https://git.openjdk.java.net/jdk pull/5899/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5899
View PR using the GUI difftool:
$ git pr show -t 5899
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5899.diff