Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252627: Make it safe for JFR thread to read threadObj #59

Closed
wants to merge 1 commit into from

Conversation

@fisk
Copy link
Contributor

@fisk fisk commented Sep 7, 2020

Migrating this review from the mailing list to a PR so I can integrate it. Already reviewed really.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252627: Make it safe for JFR thread to read threadObj

Reviewers

  • dholmes - Reviewer ⚠️ Added manually
  • mgronlun - Reviewer ⚠️ Added manually

Download

$ git fetch https://git.openjdk.java.net/jdk pull/59/head:pull/59
$ git checkout pull/59

@fisk
Copy link
Contributor Author

@fisk fisk commented Sep 7, 2020

/reviewer add dholmes

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 7, 2020

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@fisk
Reviewer dholmes successfully added.

Loading

@fisk
Copy link
Contributor Author

@fisk fisk commented Sep 7, 2020

/reviewer add mgronlun

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@fisk
Reviewer mgronlun successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@fisk The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@openjdk openjdk bot added the hotspot label Sep 7, 2020
@fisk fisk changed the title 8252627_jfr_thread_oop 8252627: Make it safe for JFR thread to read threadObj Sep 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@fisk This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252627: Make it safe for JFR thread to read threadObj

Reviewed-by: dholmes, mgronlun
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • e29c3f6: 8252661: Change SafepointMechanism terminology to talk less about "blocking"

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e29c3f61235b325d5397f0844badc377ddae7922.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 7, 2020

Webrevs

Loading

@fisk
Copy link
Contributor Author

@fisk fisk commented Sep 7, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2020

@fisk Since your change was applied there has been 1 commit pushed to the master branch:

  • e29c3f6: 8252661: Change SafepointMechanism terminology to talk less about "blocking"

Your commit was automatically rebased without conflicts.

Pushed as commit e0d5b5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

cushon pushed a commit to cushon/jdk that referenced this issue Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant