8275240: Change nested classes in jdk.attach to static nested classes

[turbanoff]

Non-static classes hold a link to their parent classes, which in many cases can be avoided.
Similar cleanup in java.base - JDK-8261880

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8275240: Change nested classes in jdk.attach to static nested classes

Reviewers

• Chris Plummer (@plummercj - Reviewer) ⚠️ Review applies to 70cb33a
• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 70cb33a
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5904/head:pull/5904
$ git checkout pull/5904

Update a local copy of the PR:
$ git checkout pull/5904
$ git pull https://git.openjdk.java.net/jdk pull/5904/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5904

View PR using the GUI difftool:
$ git pr show -t 5904

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5904.diff

[bridgekeeper]

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (06fcaa48)
• 00: Full (70cb33a9)

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275240: Change nested classes in jdk.attach to static nested classes

Reviewed-by: cjplummer, dholmes, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 40d69f0: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
• 54b8870: 8275035: Clean up worker thread infrastructure
• 3b0b6ad: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
• 8d9004b: 8274781: Use monospace font for enclosing interface
• 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
• 8b1b6f9: 8269559: AArch64: Implement string_compare intrinsic in SVE
• d9e03e4: 8275244: Suppress warnings on non-serializable array component types in jdk.management
• 7dc2db4: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
• 1e0184d: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList
• d15fbc2: 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/a5f09d1088d9dd610139370739e9fbd6e34416cb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@plummercj, @dholmes-ora, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dholmes-ora]

Seems trivially fine.

Thanks,
David

[sspitsyn]

A couple of files need a copyright year update.
Otherwise, it looks good.
Thanks,
Serguei

[turbanoff]

/integrate

[openjdk]

@turbanoff
Your change (at version 06fcaa4) is now ready to be sponsored by a Committer.

[sspitsyn]

/sponsor

[openjdk]

Going to push as commit 21df412.
Since your change was applied there have been 38 commits pushed to the master branch:

• a16f2d0: 8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security
• ede3f4e: 8274795: AArch64: avoid spilling and restoring r18 in macro assembler
• 40d69f0: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
• 54b8870: 8275035: Clean up worker thread infrastructure
• 3b0b6ad: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
• 8d9004b: 8274781: Use monospace font for enclosing interface
• 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
• 8b1b6f9: 8269559: AArch64: Implement string_compare intrinsic in SVE
• d9e03e4: 8275244: Suppress warnings on non-serializable array component types in jdk.management
• 7dc2db4: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
• ... and 28 more: https://git.openjdk.java.net/jdk/compare/a5f09d1088d9dd610139370739e9fbd6e34416cb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sspitsyn @turbanoff Pushed as commit 21df412.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.