Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275131: Exceptions after a touchpad gesture on macOS #5910

Closed
wants to merge 1 commit into from

Conversation

JB-Dmitry
Copy link
Contributor

@JB-Dmitry JB-Dmitry commented Oct 12, 2021

This is a small fix for a mistake in JDK-8257853 implementation, replacing DECLARE_METHOD JNI lookup macro with DECLARE_STATIC_METHOD in [AWTWindow_Normal postGesture:as馃叞锔b:].
I did not created a test for the fix, as AWT Robot doesn't currently support touchpad gestures.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275131: Exceptions after a touchpad gesture on macOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5910/head:pull/5910
$ git checkout pull/5910

Update a local copy of the PR:
$ git checkout pull/5910
$ git pull https://git.openjdk.java.net/jdk pull/5910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5910

View PR using the GUI difftool:
$ git pr show -t 5910

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5910.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2021

馃憢 Welcome back dbatrak! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@JB-Dmitry The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 12, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@JB-Dmitry This change now passes all automated pre-integration checks.

鈩癸笍 This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275131: Exceptions after a touchpad gesture on macOS

Reviewed-by: dmarkov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 07b1f1c: 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6
  • f623460: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception"
  • e393c5e: 8275074: Cleanup unused code in JFR LeakProfiler
  • e16b93a: 8274770: [PPC64] resolve_jobject needs a generic implementation to support load barriers
  • 1ab6414: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

鉃★笍 To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2021
prrace
prrace approved these changes Oct 12, 2021
@JB-Dmitry
Copy link
Contributor Author

JB-Dmitry commented Oct 12, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2021

Going to push as commit 89999f7.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 07b1f1c: 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6
  • f623460: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception"
  • e393c5e: 8275074: Cleanup unused code in JFR LeakProfiler
  • e16b93a: 8274770: [PPC64] resolve_jobject needs a generic implementation to support load barriers
  • 1ab6414: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@JB-Dmitry Pushed as commit 89999f7.

馃挕 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants