-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8275131: Exceptions after a touchpad gesture on macOS #5910
Conversation
👋 Welcome back dbatrak! A progress list of the required criteria for merging this PR into |
@JB-Dmitry The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@JB-Dmitry This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 89999f7.
Your commit was automatically rebased without conflicts. |
@JB-Dmitry Pushed as commit 89999f7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a small fix for a mistake in JDK-8257853 implementation, replacing DECLARE_METHOD JNI lookup macro with DECLARE_STATIC_METHOD in [AWTWindow_Normal postGesture:as:a:b:].
I did not created a test for the fix, as AWT Robot doesn't currently support touchpad gestures.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5910/head:pull/5910
$ git checkout pull/5910
Update a local copy of the PR:
$ git checkout pull/5910
$ git pull https://git.openjdk.java.net/jdk pull/5910/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5910
View PR using the GUI difftool:
$ git pr show -t 5910
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5910.diff