Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security #5913

Closed
wants to merge 2 commits into from

Conversation

fguallini
Copy link
Contributor

@fguallini fguallini commented Oct 12, 2021

This patch improves code coverage on the following classes:

  • com.sun.org.apache.xml.internal.security.algorithms.implementations.IntegrityHmac
  • com.sun.org.apache.xml.internal.security.utils.ElementProxy
  • com.sun.org.apache.xml.internal.security.keys.KeyInfo

The new tests exercise code blocks that are not currently covered by other tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5913/head:pull/5913
$ git checkout pull/5913

Update a local copy of the PR:
$ git checkout pull/5913
$ git pull https://git.openjdk.java.net/jdk pull/5913/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5913

View PR using the GUI difftool:
$ git pr show -t 5913

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5913.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 12, 2021

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Oct 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 12, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2021

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • ede3f4e: 8274795: AArch64: avoid spilling and restoring r18 in macro assembler
  • 40d69f0: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
  • 54b8870: 8275035: Clean up worker thread infrastructure
  • 3b0b6ad: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 8d9004b: 8274781: Use monospace font for enclosing interface
  • 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
  • 8b1b6f9: 8269559: AArch64: Implement string_compare intrinsic in SVE
  • d9e03e4: 8275244: Suppress warnings on non-serializable array component types in jdk.management
  • 7dc2db4: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 1e0184d: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/f62346066869b681d1cc9f63775393b11a48722a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 13, 2021
@fguallini
Copy link
Contributor Author

@fguallini fguallini commented Oct 14, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@fguallini
Your change (at version 4916eba) is now ready to be sponsored by a Committer.

@rhalade
Copy link
Member

@rhalade rhalade commented Oct 14, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

Going to push as commit a16f2d0.
Since your change was applied there have been 27 commits pushed to the master branch:

  • ede3f4e: 8274795: AArch64: avoid spilling and restoring r18 in macro assembler
  • 40d69f0: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
  • 54b8870: 8275035: Clean up worker thread infrastructure
  • 3b0b6ad: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 8d9004b: 8274781: Use monospace font for enclosing interface
  • 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
  • 8b1b6f9: 8269559: AArch64: Implement string_compare intrinsic in SVE
  • d9e03e4: 8275244: Suppress warnings on non-serializable array component types in jdk.management
  • 7dc2db4: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 1e0184d: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/f62346066869b681d1cc9f63775393b11a48722a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@rhalade @fguallini Pushed as commit a16f2d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants