Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode #5919

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 12, 2021

A trivial fix to ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64
and windows-x64 in -Xcomp mode.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5919/head:pull/5919
$ git checkout pull/5919

Update a local copy of the PR:
$ git checkout pull/5919
$ git pull https://git.openjdk.java.net/jdk pull/5919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5919

View PR using the GUI difftool:
$ git pr show -t 5919

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5919.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 12, 2021

/label add hotspot-runtime
/label add hotspot-compiler

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 12, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime label Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-compiler label Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode

Reviewed-by: iignatyev

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 03c2b73: 8275128: Build hsdis using normal build system

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 12, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 12, 2021

@iignatev - Thanks for the lightning fast review!

/integrate

vidmik
vidmik approved these changes Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

Going to push as commit b1b8350.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 03c2b73: 8275128: Build hsdis using normal build system

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@dcubed-ojdk Pushed as commit b1b8350.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev
Copy link
Member

@iignatev iignatev commented Oct 12, 2021

@vidmik too slow :)

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 12, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 12, 2021

@vidmik - Thanks for the review, but I integrated too quickly...

@dcubed-ojdk dcubed-ojdk deleted the JDK-8275171 branch Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-runtime integrated
3 participants