Skip to content

8254352: 3 compiler tests failed with "assert(allocates2(pc)) failed: not in CodeBuffer memory" #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Oct 11, 2020

JDK-8252847 changes added new AVX3 specific stubs for arraycopy and increased code buffer size but it was not enough.
On Windows we need 3500 bytes more because additional code is used to preserve registers.

Tested hs tier1-3 and ran bug's tests on machine where they failed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254352: 3 compiler tests failed with "assert(allocates2(pc)) failed: not in CodeBuffer memory"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/592/head:pull/592
$ git checkout pull/592

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2020

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2020
@openjdk
Copy link

openjdk bot commented Oct 11, 2020

@vnkozlov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 11, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2020

Webrevs

@shipilev
Copy link
Member

shipilev commented Oct 11, 2020

Note: you would not be able to integrate until PR and issue title match, see "Integration Blocker" notice in the PR body.

@vnkozlov vnkozlov changed the title 8254352: 3 compiler tests failed with "assert(allocates2(pc)) failed" 8254352: 3 compiler tests failed with "assert(allocates2(pc)) failed: not in CodeBuffer memory" Oct 11, 2020
@openjdk
Copy link

openjdk bot commented Oct 11, 2020

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254352: 3 compiler tests failed with "assert(allocates2(pc)) failed: not in CodeBuffer memory"

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2020
@vnkozlov
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Oct 11, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2020
@openjdk
Copy link

openjdk bot commented Oct 11, 2020

@vnkozlov Pushed as commit 25001c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov vnkozlov deleted the JDK-8254352 branch October 11, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants