Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 #5921

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 13, 2021

Hi all,

May I get reviews for this change?

The fix just follows what is done for test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestRunTests.java in JDK-8274911.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5921/head:pull/5921
$ git checkout pull/5921

Update a local copy of the PR:
$ git checkout pull/5921
$ git pull https://git.openjdk.java.net/jdk pull/5921/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5921

View PR using the GUI difftool:
$ git pr show -t 5921

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5921.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@DamonFool To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@DamonFool
Copy link
Member Author

DamonFool commented Oct 13, 2021

/label hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@DamonFool
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 13, 2021

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good and trivial! Thanks for fixing that - I forgot that test because my repo was outdated

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ab34cce: 8275186: Suppress warnings on non-serializable array component types in xml
  • b1b8350: 8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode
  • 03c2b73: 8275128: Build hsdis using normal build system

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me too.

@dcubed-ojdk
Copy link
Member

dcubed-ojdk commented Oct 13, 2021

Since this bug is causing 4 test failures per Tier5, please do not wait for 24 hours
before pushing this fix.

@DamonFool
Copy link
Member Author

DamonFool commented Oct 13, 2021

Since this bug is causing 4 test failures per Tier5, please do not wait for 24 hours before pushing this fix.

Okay.
Thanks @chhagedorn and @TobiHartmann for your review.
/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

Going to push as commit 451a296.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 5ffb5d1: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules
  • b8cb76a: 8273682: Upgrade Jline to 3.20.0
  • dcf428c: 8275075: Remove unnecessary conversion to String in jdk.hotspot.agent
  • c3b75c6: 8274516: [REDO] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references
  • 337b73a: 8274851: [PPC64] Port zgc to linux on ppc64le
  • cf82867: 8275049: [ZGC] missing null check in ZNMethod::log_register
  • ab34cce: 8275186: Suppress warnings on non-serializable array component types in xml
  • b1b8350: 8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode
  • 03c2b73: 8275128: Build hsdis using normal build system

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@DamonFool Pushed as commit 451a296.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8275173 branch Oct 13, 2021
@dcubed-ojdk
Copy link
Member

dcubed-ojdk commented Oct 13, 2021

@DamonFool - Just realized I forgot to ask what testing you did...

@DamonFool
Copy link
Member Author

DamonFool commented Oct 13, 2021

@DamonFool - Just realized I forgot to ask what testing you did...

I tested the affected test on my mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants