Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8275186: Suppress warnings on non-serializable array component types in xml #5924

Closed
wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Oct 13, 2021

After a refinement to the checks under development in #5709, the new checks examine array types of serial fields and warn if the underlying component type is not serializable. Per the JLS, all array types are serializable, but if the base component is not serializable, the serialization process can throw an exception.

From "Java Object Serialization Specification: 2 - Object Output Classes":

"If the object is an array, writeObject is called recursively to write the ObjectStreamClass of the array. The handle for the array is assigned. It is followed by the length of the array. Each element of the array is then written to the stream, after which writeObject returns."


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275186: Suppress warnings on non-serializable array component types in xml

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5924/head:pull/5924
$ git checkout pull/5924

Update a local copy of the PR:
$ git checkout pull/5924
$ git pull https://git.openjdk.java.net/jdk pull/5924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5924

View PR using the GUI difftool:
$ git pr show -t 5924

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5924.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 13, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2021

Webrevs

@JoeWang-Java
Copy link
Member

JoeWang-Java commented Oct 13, 2021

I understand you'd update the header before push. Pls note that there's a "@lastmodified" field that would need to be updated as well. Thanks.

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275186: Suppress warnings on non-serializable array component types in xml

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2021
@jddarcy
Copy link
Member Author

jddarcy commented Oct 13, 2021

I understand you'd update the header before push. Pls note that there's a "@lastmodified" field that would need to be updated as well. Thanks.

Hi Joe,

I ran my copyright update script this time before sending out the review; I'll check for the "@lastmodified" fields before pushing.

Thanks,

-Joe

@jddarcy
Copy link
Member Author

jddarcy commented Oct 13, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

Going to push as commit ab34cce.

@openjdk openjdk bot closed this Oct 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@jddarcy Pushed as commit ab34cce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8275186 branch Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants