Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges #5929

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Oct 13, 2021

I believe for the cases that there is no plain read on atomic variables, we can relax memory ordering constraints for claiming tasks/ranges by workers.

Test:

  • hotspot_gc_shenandoah (fastdebug + release) on x86_64 and aarch64 Linux

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5929/head:pull/5929
$ git checkout pull/5929

Update a local copy of the PR:
$ git checkout pull/5929
$ git pull https://git.openjdk.java.net/jdk pull/5929/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5929

View PR using the GUI difftool:
$ git pr show -t 5929

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5929.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 13, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2021

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Yes, all these look like plain atomic-counter CASes. Nothing seems to depend on their memory semantics.

@openjdk
Copy link

openjdk bot commented Oct 14, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 8b1b6f9: 8269559: AArch64: Implement string_compare intrinsic in SVE
  • d9e03e4: 8275244: Suppress warnings on non-serializable array component types in jdk.management
  • 7dc2db4: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 1e0184d: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList
  • d15fbc2: 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset
  • d8f6b6c: 8274718: runtime/cds/appcds/LambdaEagerInit.java fails with -XX:-CompactStrings
  • 451a296: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911
  • 5ffb5d1: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules
  • b8cb76a: 8273682: Upgrade Jline to 3.20.0
  • dcf428c: 8275075: Remove unnecessary conversion to String in jdk.hotspot.agent
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/75f5145e21a1320c1a08080af861497ce7c3f266...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2021
@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Oct 14, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2021

Going to push as commit 3b0b6ad.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 8d9004b: 8274781: Use monospace font for enclosing interface
  • 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE
  • 8b1b6f9: 8269559: AArch64: Implement string_compare intrinsic in SVE
  • d9e03e4: 8275244: Suppress warnings on non-serializable array component types in jdk.management
  • 7dc2db4: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 1e0184d: 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList
  • d15fbc2: 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset
  • d8f6b6c: 8274718: runtime/cds/appcds/LambdaEagerInit.java fails with -XX:-CompactStrings
  • 451a296: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911
  • 5ffb5d1: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/75f5145e21a1320c1a08080af861497ce7c3f266...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 14, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2021
@openjdk
Copy link

openjdk bot commented Oct 14, 2021

@zhengyu123 Pushed as commit 3b0b6ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
2 participants