8254362: x86_32 builds fail after JDK-8253180

[shipilev]

r15_thread is not available on x86_32. I noticed that JDK-8253180 introduces:

void C1SafepointPollStub::emit_code(LIR_Assembler* ce) {
#ifdef _LP64
...
  __ movptr(Address(r15_thread, JavaThread::saved_exception_pc_offset()), rscratch1);
...
#else
  ShouldNotReachHere();
#endif /* _LP64 */
}

...and we should do the same in C2SafepointPollStubTable to unbreak x86_32.

Testing:

• x86_32 build
• x86_32 hotspot:tier1 (lots of unrelated failures that look like JDK-8254125, never a ShouldNotReachHere)
• x86_64 build
• x86_64 hotspot:tier1

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8254362: x86_32 builds fail after JDK-8253180

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/593/head:pull/593
$ git checkout pull/593

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (29b3751)

[vnkozlov]

Good.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254362: x86_32 builds fail after JDK-8253180

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 25001c5: 8254352: 3 compiler tests failed with "assert(allocates2(pc)) failed: not in CodeBuffer memory"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there has been 1 commit pushed to the master branch:

• 25001c5: 8254352: 3 compiler tests failed with "assert(allocates2(pc)) failed: not in CodeBuffer memory"

Your commit was automatically rebased without conflicts.

Pushed as commit d3069ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.