Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275234 : java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList #5932

Closed
wants to merge 1 commit into from

Conversation

lawrence-andrew
Copy link
Contributor

@lawrence-andrew lawrence-andrew commented Oct 13, 2021

java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in the problemList.txt
jtreg always picks the second entry not the first one and user expects that test should be executed on the first entry platform but it executes.

@shurymury


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5932/head:pull/5932
$ git checkout pull/5932

Update a local copy of the PR:
$ git checkout pull/5932
$ git pull https://git.openjdk.java.net/jdk pull/5932/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5932

View PR using the GUI difftool:
$ git pr show -t 5932

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5932.diff

@lawrence-andrew
Copy link
Contributor Author

/label client

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2021

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList

Reviewed-by: serb, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d15fbc2: 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @pankaj-bansal) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review client client-libs-dev@openjdk.org labels Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@lawrence-andrew
The client label was successfully added.

@lawrence-andrew
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@lawrence-andrew
Your change (at version 41ff1e1) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Oct 13, 2021

Webrevs

@mrserb
Copy link
Member

mrserb commented Oct 13, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

Going to push as commit 1e0184d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • d15fbc2: 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@mrserb @lawrence-andrew Pushed as commit 1e0184d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants