Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275265: java/nio/channels tests needing large heap sizes fail on x86_32 #5942

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 14, 2021

Hi all,

java/nio/channels/FileChannel/LargeGatheringWrite.java and java/nio/channels/Channels/ReadXBytes.java fail on x86_32.

This is because they require -Xmx4G and -Xmx8G, which are invalid on 32-bit platforms.
So let's exclude them on 32-bit platforms.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275265: java/nio/channels tests needing large heap sizes fail on x86_32

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5942/head:pull/5942
$ git checkout pull/5942

Update a local copy of the PR:
$ git checkout pull/5942
$ git pull https://git.openjdk.java.net/jdk pull/5942/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5942

View PR using the GUI difftool:
$ git pr show -t 5942

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5942.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@DamonFool DamonFool changed the title 8275265: Two java/nio/channels tests fails on x86_32 8275265: java/nio/channels tests needing large heap sizes fail on x86_32 Oct 14, 2021
@openjdk openjdk bot added the rfr label Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio label Oct 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 14, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275265: java/nio/channels tests needing large heap sizes fail on x86_32

Reviewed-by: alanb, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 40d69f0: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
  • 54b8870: 8275035: Clean up worker thread infrastructure
  • 3b0b6ad: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 8d9004b: 8274781: Use monospace font for enclosing interface
  • 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 14, 2021
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Oct 14, 2021

Thanks @AlanBateman .

Will push it tomorrow if there is no objection.
Thanks.

bplb
bplb approved these changes Oct 14, 2021
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Oct 14, 2021

Thanks @bplb .
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

Going to push as commit 9623d5b.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 21df412: 8275240: Change nested classes in jdk.attach to static nested classes
  • a16f2d0: 8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security
  • ede3f4e: 8274795: AArch64: avoid spilling and restoring r18 in macro assembler
  • 40d69f0: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"
  • 54b8870: 8275035: Clean up worker thread infrastructure
  • 3b0b6ad: 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges
  • 8d9004b: 8274781: Use monospace font for enclosing interface
  • 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@DamonFool Pushed as commit 9623d5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8275265 branch Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated nio
3 participants