Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8274781: Use monospace font for enclosing interface #5945

Closed
wants to merge 3 commits into from

Conversation

hns
Copy link
Member

@hns hns commented Oct 14, 2021

Please review a trivial change to have the enclosing interface/class link in the class page displayed in monospace font like other similar links.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274781: Use monospace font for enclosing interface

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5945/head:pull/5945
$ git checkout pull/5945

Update a local copy of the PR:
$ git checkout pull/5945
$ git pull https://git.openjdk.java.net/jdk pull/5945/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5945

View PR using the GUI difftool:
$ git pr show -t 5945

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5945.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2021

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2021
@openjdk
Copy link

openjdk bot commented Oct 14, 2021

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Oct 14, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2021

Webrevs

Copy link
Member

@pavelrappo pavelrappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Comment on lines 384 to 386
Content dd = new HtmlTree(TagName.DD);
dd.add(getLink(new HtmlLinkInfo(configuration,
HtmlLinkInfo.Kind.CLASS, e)));
dd.add(getClassLinks(HtmlLinkInfo.Kind.CLASS, List.of(e)));
dl.add(dd);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could fold these four lines into one line for consistency with similar code in this file:

dl.add(HtmlTree.DD(getClassLinks(HtmlLinkInfo.Kind.CLASS, List.of(e))));

@openjdk
Copy link

openjdk bot commented Oct 14, 2021

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274781: Use monospace font for enclosing interface

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2021

Mailing list message from Pavel Rappo on javadoc-dev:

Clarification for "these four lines".

The GitHub snippet looks different from that of the javadoc-dev mailing list. Not only do the line numbers differ, but the contents differ too. Sadly, in some cases, an OpenJDK mailing list is a poor substitute for the GitHub web interface.

-Pavel

@hns
Copy link
Member Author

hns commented Oct 14, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2021

Going to push as commit 8d9004b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 333c469: 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 14, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2021
@openjdk
Copy link

openjdk bot commented Oct 14, 2021

@hns Pushed as commit 8d9004b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants