New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8274781: Use monospace font for enclosing interface #5945
Conversation
|
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Content dd = new HtmlTree(TagName.DD); | ||
dd.add(getLink(new HtmlLinkInfo(configuration, | ||
HtmlLinkInfo.Kind.CLASS, e))); | ||
dd.add(getClassLinks(HtmlLinkInfo.Kind.CLASS, List.of(e))); | ||
dl.add(dd); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could fold these four lines into one line for consistency with similar code in this file:
dl.add(HtmlTree.DD(getClassLinks(HtmlLinkInfo.Kind.CLASS, List.of(e))));
@hns This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Mailing list message from Pavel Rappo on javadoc-dev: Clarification for "these four lines". The GitHub snippet looks different from that of the javadoc-dev mailing list. Not only do the line numbers differ, but the contents differ too. Sadly, in some cases, an OpenJDK mailing list is a poor substitute for the GitHub web interface. -Pavel |
/integrate |
Please review a trivial change to have the enclosing interface/class link in the class page displayed in monospace font like other similar links.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5945/head:pull/5945
$ git checkout pull/5945
Update a local copy of the PR:
$ git checkout pull/5945
$ git pull https://git.openjdk.java.net/jdk pull/5945/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5945
View PR using the GUI difftool:
$ git pr show -t 5945
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5945.diff