8275145: file.encoding system property has an incorrect value on Windows

[naotoj]

Fixing a regression in which file.encoding was initialized by sprops->encoding instead of sprops->sun_jnu_encoding on non macOS platforms. tier1-3 tests passed on all platforms.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8275145: file.encoding system property has an incorrect value on Windows

Reviewers

• Mandy Chung (@mlchung - Reviewer)
• Iris Clark (@irisclark - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5953/head:pull/5953
$ git checkout pull/5953

Update a local copy of the PR:
$ git checkout pull/5953
$ git pull https://git.openjdk.java.net/jdk pull/5953/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5953

View PR using the GUI difftool:
$ git pr show -t 5953

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5953.diff

[bridgekeeper]

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@naotoj The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (13d7c51a)

[openjdk]

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275145: file.encoding system property has an incorrect value on Windows

Reviewed-by: mchung, iris, rriggs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

• f178185: 8275249: Suppress warnings on non-serializable array component types in jdk.jlink
• ee64ce9: 8274937: Revert the timeout setting for DynamicLoaderConstraintsTest
• 8c4da9c: 8275013: Improve discussion of serialization method declarations in java.io.Object{Input, Output}Stream
• da8da3a: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing
• 8e02064: 8049520: FileCredentialsCache loads cache once and is never refreshed
• 172aed1: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
• ced7909: 8275286: Check current thread when calling JRT methods that expect it
• c0f3e1d: 8271071: accessibility of a table on macOS lacks cell navigation
• 4cb7124: 8262912: ciReplay: replay does not simulate unresolved classes
• 322b130: 8275106: Cleanup Iterator usages in java.desktop
• ... and 70 more: https://git.openjdk.java.net/jdk/compare/ec199072c5867624d66840238cc8828e16ae8da7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jddarcy]

/csr needed

[jddarcy]

Please file a CSR for the change in behavior.

[openjdk]

@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@naotoj please create a CSR request for issue JDK-8275145. This pull request cannot be integrated until the CSR request is approved.

[naotoj]

Filed a CSR: https://bugs.openjdk.java.net/browse/JDK-8275309

[naotoj]

/integrate

[openjdk]

Going to push as commit ad9e234.
Since your change was applied there have been 80 commits pushed to the master branch:

• f178185: 8275249: Suppress warnings on non-serializable array component types in jdk.jlink
• ee64ce9: 8274937: Revert the timeout setting for DynamicLoaderConstraintsTest
• 8c4da9c: 8275013: Improve discussion of serialization method declarations in java.io.Object{Input, Output}Stream
• da8da3a: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing
• 8e02064: 8049520: FileCredentialsCache loads cache once and is never refreshed
• 172aed1: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
• ced7909: 8275286: Check current thread when calling JRT methods that expect it
• c0f3e1d: 8271071: accessibility of a table on macOS lacks cell navigation
• 4cb7124: 8262912: ciReplay: replay does not simulate unresolved classes
• 322b130: 8275106: Cleanup Iterator usages in java.desktop
• ... and 70 more: https://git.openjdk.java.net/jdk/compare/ec199072c5867624d66840238cc8828e16ae8da7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj Pushed as commit ad9e234.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.