Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275145: file.encoding system property has an incorrect value on Windows #5953

Closed
wants to merge 1 commit into from

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Oct 14, 2021

Fixing a regression in which file.encoding was initialized by sprops->encoding instead of sprops->sun_jnu_encoding on non macOS platforms. tier1-3 tests passed on all platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275145: file.encoding system property has an incorrect value on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5953/head:pull/5953
$ git checkout pull/5953

Update a local copy of the PR:
$ git checkout pull/5953
$ git pull https://git.openjdk.java.net/jdk pull/5953/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5953

View PR using the GUI difftool:
$ git pr show -t 5953

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5953.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@naotoj The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Oct 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 14, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275145: file.encoding system property has an incorrect value on Windows

Reviewed-by: mchung, iris, rriggs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • f178185: 8275249: Suppress warnings on non-serializable array component types in jdk.jlink
  • ee64ce9: 8274937: Revert the timeout setting for DynamicLoaderConstraintsTest
  • 8c4da9c: 8275013: Improve discussion of serialization method declarations in java.io.Object{Input, Output}Stream
  • da8da3a: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing
  • 8e02064: 8049520: FileCredentialsCache loads cache once and is never refreshed
  • 172aed1: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • ced7909: 8275286: Check current thread when calling JRT methods that expect it
  • c0f3e1d: 8271071: accessibility of a table on macOS lacks cell navigation
  • 4cb7124: 8262912: ciReplay: replay does not simulate unresolved classes
  • 322b130: 8275106: Cleanup Iterator usages in java.desktop
  • ... and 70 more: https://git.openjdk.java.net/jdk/compare/ec199072c5867624d66840238cc8828e16ae8da7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 14, 2021
@jddarcy
Copy link
Member

@jddarcy jddarcy commented Oct 14, 2021

/csr needed

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Oct 14, 2021

Please file a CSR for the change in behavior.

@openjdk openjdk bot added the csr label Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@naotoj please create a CSR request for issue JDK-8275145. This pull request cannot be integrated until the CSR request is approved.

@openjdk openjdk bot removed the ready label Oct 14, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Oct 14, 2021

@openjdk openjdk bot added ready and removed csr labels Oct 15, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Oct 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

Going to push as commit ad9e234.
Since your change was applied there have been 80 commits pushed to the master branch:

  • f178185: 8275249: Suppress warnings on non-serializable array component types in jdk.jlink
  • ee64ce9: 8274937: Revert the timeout setting for DynamicLoaderConstraintsTest
  • 8c4da9c: 8275013: Improve discussion of serialization method declarations in java.io.Object{Input, Output}Stream
  • da8da3a: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing
  • 8e02064: 8049520: FileCredentialsCache loads cache once and is never refreshed
  • 172aed1: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • ced7909: 8275286: Check current thread when calling JRT methods that expect it
  • c0f3e1d: 8271071: accessibility of a table on macOS lacks cell navigation
  • 4cb7124: 8262912: ciReplay: replay does not simulate unresolved classes
  • 322b130: 8275106: Cleanup Iterator usages in java.desktop
  • ... and 70 more: https://git.openjdk.java.net/jdk/compare/ec199072c5867624d66840238cc8828e16ae8da7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

@naotoj Pushed as commit ad9e234.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants