New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274937: Revert the timeout setting for DynamicLoaderConstraintsTest #5961
8274937: Revert the timeout setting for DynamicLoaderConstraintsTest #5961
Conversation
|
/label add hotspot-runtime |
@calvinccheung |
@calvinccheung This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks Dan and Yumin for the review. |
Going to push as commit ee64ce9.
Your commit was automatically rebased without conflicts. |
@calvinccheung Pushed as commit ee64ce9. |
Since JDK-8273612 has been fixed, the increase in the timeout for DynamicLoaderConstraintsTest could be reverted.
Tested with the following VM options on the macosx-x64 platform with fastdebug build with jtreg timeout factor set to 15.
-Xcomp -XX:+CreateCoredumpOnCrash -ea -esa -XX:CompileThreshold=100 -XX:+UnlockExperimentalVMOptions -server -XX:+TieredCompilation -XX:-UseCompressedOops
Test was repeated 20 times with no timeout observed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5961/head:pull/5961
$ git checkout pull/5961
Update a local copy of the PR:
$ git checkout pull/5961
$ git pull https://git.openjdk.java.net/jdk pull/5961/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5961
View PR using the GUI difftool:
$ git pr show -t 5961
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5961.diff