Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275277: assert(dest_attr.is_in_cset() == (obj->forwardee() == obj)) failed: Only evac-failed objects must be in the collection set here but <addr> is not #5965

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Oct 15, 2021

Hi all,

can I have reviews for this fix of an incomplete assert?

When checking whether the forwardee equals the object, we first need to check whether the object is already forwarded, otherwise we might get false positives. See CR for more details (example).

Testing: gha, failing tests do not fail after 2k repetitions

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275277: assert(dest_attr.is_in_cset() == (obj->forwardee() == obj)) failed: Only evac-failed objects must be in the collection set here but is not

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5965/head:pull/5965
$ git checkout pull/5965

Update a local copy of the PR:
$ git checkout pull/5965
$ git pull https://git.openjdk.java.net/jdk pull/5965/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5965

View PR using the GUI difftool:
$ git pr show -t 5965

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5965.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 15, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 15, 2021
@tschatzl tschatzl marked this pull request as ready for review Oct 15, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 15, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2021

Webrevs

Copy link
Member

@albertnetymk albertnetymk left a comment

Ofc obj could be outside cset, and it's dangerous to call forwardee directly... Thank you for the analysis and the fix.

@openjdk
Copy link

openjdk bot commented Oct 15, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275277: assert(dest_attr.is_in_cset() == (obj->forwardee() == obj)) failed: Only evac-failed objects must be in the collection set here but <addr> is not

Reviewed-by: ayang, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 172aed1: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • ced7909: 8275286: Check current thread when calling JRT methods that expect it
  • c0f3e1d: 8271071: accessibility of a table on macOS lacks cell navigation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 15, 2021
Copy link
Contributor

@rkennke rkennke left a comment

I've stumbled over the same thing, and came up with same solution. Looks good!

@tschatzl
Copy link
Contributor Author

tschatzl commented Oct 16, 2021

Thanks @albertnetymk @rkennke for your reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 16, 2021

Going to push as commit bfcf6a2.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 96fef40: 8189591: No way to locally suppress doclint warnings
  • 7fc3a8d: 8275149: (ch) ReadableByteChannel returned by Channels.newChannel(InputStream) throws ReadOnlyBufferException
  • 831802d: 8275163: Deflater::deflate methods omit javadoc for ReadOnlyBufferException
  • ad9e234: 8275145: file.encoding system property has an incorrect value on Windows
  • f178185: 8275249: Suppress warnings on non-serializable array component types in jdk.jlink
  • ee64ce9: 8274937: Revert the timeout setting for DynamicLoaderConstraintsTest
  • 8c4da9c: 8275013: Improve discussion of serialization method declarations in java.io.Object{Input, Output}Stream
  • da8da3a: 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing
  • 8e02064: 8049520: FileCredentialsCache loads cache once and is never refreshed
  • 172aed1: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/4cb7124c1e9c5fd1d3a82fd8933cc63fefde9531...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2021
@openjdk
Copy link

openjdk bot commented Oct 16, 2021

@tschatzl Pushed as commit bfcf6a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8275277-failed-forwarding-assert branch Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants