Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" #5969

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Oct 15, 2021

Move the initialization and potential class loading of the MethodType out of eatMemory so that we don't get this OOME while loading this class.
Tested with tier5 and 7.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5969/head:pull/5969
$ git checkout pull/5969

Update a local copy of the PR:
$ git checkout pull/5969
$ git pull https://git.openjdk.java.net/jdk pull/5969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5969

View PR using the GUI difftool:
$ git pr show -t 5969

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5969.diff

…ion.java failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 15, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Oct 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 15, 2021

Webrevs

@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Oct 18, 2021

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime label Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@coleenp
The hotspot-runtime label was successfully added.

Copy link
Member

@hseigel hseigel left a comment

The changes look good and trivial.
Thanks, Harold

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"

Reviewed-by: hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • a579483: 8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent
  • 002c538: 8275287: Relax memory ordering constraints on updating instance class and array class counters
  • 98ab4b0: 8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
  • dcd6e0d: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline
  • d17d81a: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator
  • a4491f2: 8275413: Remove unused InstanceKlass::set_array_klasses() method
  • 9d191fc: 8245095: Implementation of JEP 408: Simple Web Server
  • 947d52c: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
  • a03119c: 8275436: [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect
  • bad75e6: 8275150: URLClassLoaderTable should store OopHandle instead of Handle
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/a16f2d0a3c326dd8b3b2133a9c170d998b7aa631...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 19, 2021
@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Oct 21, 2021

Thanks Harold!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

Going to push as commit cd07b3c.
Since your change was applied there have been 100 commits pushed to the master branch:

  • 819d2df: 8274794: Print all owned locks in hs_err file
  • c41ce6d: 8275415: Prepare Leak Profiler for Lilliput
  • 0c3eaea: 8168388: GetMousePositionTest fails with the message "Mouse position should not be null"
  • 09f5235: 8275405: Linking error for classes with lambda template parameters and virtual functions
  • a120937: 8274988: G1: refine G1SegmentedArrayAllocOptions and G1CardSetAllocOptions
  • c7a80e6: 8275607: G1: G1CardSetAllocator::drop_all needs to call G1SegmentedArray::drop_all
  • af7c56b: 8275167: x86 intrinsic for unsignedMultiplyHigh
  • cea3f01: 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless
  • d1e3ca4: 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos
  • 913f928: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test
  • ... and 90 more: https://git.openjdk.java.net/jdk/compare/a16f2d0a3c326dd8b3b2133a9c170d998b7aa631...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@coleenp Pushed as commit cd07b3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the oome branch Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-runtime integrated
2 participants