Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275287: Relax memory ordering constraints on updating instance class and array class counters #5970

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Oct 15, 2021

The same as JDK-8261600, the counters only need atomic guarantee, so that, their memory constraints can be relaxed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275287: Relax memory ordering constraints on updating instance class and array class counters

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5970/head:pull/5970
$ git checkout pull/5970

Update a local copy of the PR:
$ git checkout pull/5970
$ git pull https://git.openjdk.java.net/jdk pull/5970/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5970

View PR using the GUI difftool:
$ git pr show -t 5970

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5970.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 15, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

@zhengyu123 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Oct 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 15, 2021

Webrevs

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Oct 18, 2021

The same as JDK-8275287

?? this is JDK-8275287. :)

Copy link
Member

@dholmes-ora dholmes-ora left a comment

This seems fine.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275287: Relax memory ordering constraints on updating instance class and array class counters

Reviewed-by: dholmes, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 98ab4b0: 8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
  • dcd6e0d: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline
  • d17d81a: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator
  • a4491f2: 8275413: Remove unused InstanceKlass::set_array_klasses() method
  • 9d191fc: 8245095: Implementation of JEP 408: Simple Web Server
  • 947d52c: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
  • a03119c: 8275436: [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect
  • bad75e6: 8275150: URLClassLoaderTable should store OopHandle instead of Handle
  • 72a976e: 8266936: Add a finalization JFR event
  • bcbe384: 8269175: [macosx-aarch64] wrong CPU speed in hs_err file
  • ... and 32 more: https://git.openjdk.java.net/jdk/compare/3b0b6adc3d547fcf4b971536d2404c342d18046f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 18, 2021
@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Oct 18, 2021

The same as JDK-8275287

?? this is JDK-8275287. :)

Oops, should be JDK-8261600

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Oct 18, 2021

This seems fine.

Thanks, David

Thanks for the review, David.

Copy link
Contributor

@rkennke rkennke left a comment

Looks good to me.

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Oct 19, 2021

Thanks, @rkennke

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Oct 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

Going to push as commit 002c538.
Since your change was applied there have been 42 commits pushed to the master branch:

  • 98ab4b0: 8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
  • dcd6e0d: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline
  • d17d81a: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator
  • a4491f2: 8275413: Remove unused InstanceKlass::set_array_klasses() method
  • 9d191fc: 8245095: Implementation of JEP 408: Simple Web Server
  • 947d52c: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
  • a03119c: 8275436: [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect
  • bad75e6: 8275150: URLClassLoaderTable should store OopHandle instead of Handle
  • 72a976e: 8266936: Add a finalization JFR event
  • bcbe384: 8269175: [macosx-aarch64] wrong CPU speed in hs_err file
  • ... and 32 more: https://git.openjdk.java.net/jdk/compare/3b0b6adc3d547fcf4b971536d2404c342d18046f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@zhengyu123 Pushed as commit 002c538.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants