Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275384: Change nested classes in jdk.jconsole to static nested classes #5974

Closed

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Oct 16, 2021

Non-static classes hold a link to their parent classes, which can be avoided.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275384: Change nested classes in jdk.jconsole to static nested classes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5974/head:pull/5974
$ git checkout pull/5974

Update a local copy of the PR:
$ git checkout pull/5974
$ git pull https://git.openjdk.java.net/jdk pull/5974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5974

View PR using the GUI difftool:
$ git pr show -t 5974

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5974.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 16, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Oct 16, 2021
@turbanoff turbanoff changed the title [PATCH] Change nested classes in jdk.jconsole to static nested classes 8275384: Change nested classes in jdk.jconsole to static nested classes Oct 18, 2021
@openjdk openjdk bot added the rfr label Oct 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 18, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275384: Change nested classes in jdk.jconsole to static nested classes

Reviewed-by: alanb, sspitsyn, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 95 new commits pushed to the master branch:

  • 0961de4: 8275347: ciReplay: staticfield lines not properly terminated
  • 7dd8237: 8275084: CDS warning when building with LOG=debug
  • 49f9d80: 8243585: AlgorithmChecker::check throws confusing exception when it rejects the signer key
  • bef8cf1: 8275714: G1: remove unused variable in G1Policy::transfer_survivors_to_cset
  • af14650: 8275569: Add linux-aarch64 to test-make profiles
  • 0761a4b: 8275688: Suppress warnings on non-serializable non-transient instance fields in DualPivotQuicksort
  • 3cb241a: 8275686: Suppress warnings on non-serializable non-transient instance fields in java.rmi
  • 3b0ce23: 8274888: Dump "-DReproduce=true" to the test VM command line output
  • d589b66: 8270380: Change the default value of the java.security.manager system property to disallow
  • e39bdc9: 8274714: Incorrect verifier protected access error message
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/bfcf6a29a16bc12d77a897fbec304868957c3188...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @sspitsyn, @mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 18, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 21, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@turbanoff
Your change (at version b6c1d76) is now ready to be sponsored by a Committer.

@mlchung
Copy link
Member

@mlchung mlchung commented Oct 21, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

Going to push as commit 4e9dd4b.
Since your change was applied there have been 95 commits pushed to the master branch:

  • 0961de4: 8275347: ciReplay: staticfield lines not properly terminated
  • 7dd8237: 8275084: CDS warning when building with LOG=debug
  • 49f9d80: 8243585: AlgorithmChecker::check throws confusing exception when it rejects the signer key
  • bef8cf1: 8275714: G1: remove unused variable in G1Policy::transfer_survivors_to_cset
  • af14650: 8275569: Add linux-aarch64 to test-make profiles
  • 0761a4b: 8275688: Suppress warnings on non-serializable non-transient instance fields in DualPivotQuicksort
  • 3cb241a: 8275686: Suppress warnings on non-serializable non-transient instance fields in java.rmi
  • 3b0ce23: 8274888: Dump "-DReproduce=true" to the test VM command line output
  • d589b66: 8270380: Change the default value of the java.security.manager system property to disallow
  • e39bdc9: 8274714: Incorrect verifier protected access error message
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/bfcf6a29a16bc12d77a897fbec304868957c3188...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@mlchung @turbanoff Pushed as commit 4e9dd4b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
4 participants