-
Notifications
You must be signed in to change notification settings - Fork 6k
8275384: Change nested classes in jdk.jconsole to static nested classes #5974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8275384: Change nested classes in jdk.jconsole to static nested classes #5974
Conversation
👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into |
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 95 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @sspitsyn, @mlchung) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@turbanoff |
/sponsor |
Going to push as commit 4e9dd4b.
Your commit was automatically rebased without conflicts. |
@mlchung @turbanoff Pushed as commit 4e9dd4b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Non-static classes hold a link to their parent classes, which can be avoided.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5974/head:pull/5974
$ git checkout pull/5974
Update a local copy of the PR:
$ git checkout pull/5974
$ git pull https://git.openjdk.java.net/jdk pull/5974/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5974
View PR using the GUI difftool:
$ git pr show -t 5974
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5974.diff