8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac #5976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac fails on Mac. The test fails on my local machine (macOS BigSur) always and on mach5 also. The test uses Robot for mouse clicks and there is no delay or autoDelay set on Robot.
The fix adds set autoDelay on the robot. Along with this, a lot of cleanup is done including removing the local Semaphore class etc. The test passes after the changes on my local mac and mach5 (Link in the JBS)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5976/head:pull/5976
$ git checkout pull/5976
Update a local copy of the PR:
$ git checkout pull/5976
$ git pull https://git.openjdk.java.net/jdk pull/5976/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5976
View PR using the GUI difftool:
$ git pr show -t 5976
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5976.diff