Skip to content

8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac #5976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Oct 17, 2021

Test java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac fails on Mac. The test fails on my local machine (macOS BigSur) always and on mach5 also. The test uses Robot for mouse clicks and there is no delay or autoDelay set on Robot.

The fix adds set autoDelay on the robot. Along with this, a lot of cleanup is done including removing the local Semaphore class etc. The test passes after the changes on my local mac and mach5 (Link in the JBS)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5976/head:pull/5976
$ git checkout pull/5976

Update a local copy of the PR:
$ git checkout pull/5976
$ git pull https://git.openjdk.java.net/jdk pull/5976/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5976

View PR using the GUI difftool:
$ git pr show -t 5976

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5976.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2021

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2021

@pankaj-bansal The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 17, 2021
@pankaj-bansal pankaj-bansal marked this pull request as ready for review October 19, 2021 05:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2021

Webrevs

@pankaj-bansal pankaj-bansal deleted the JDK-8198626 branch November 5, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant