Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275385: Change nested classes in jdk.jdi to static nested classes #5978

Closed

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Oct 17, 2021

Non-static classes hold a link to their parent classes, which can be avoided.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275385: Change nested classes in jdk.jdi to static nested classes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5978/head:pull/5978
$ git checkout pull/5978

Update a local copy of the PR:
$ git checkout pull/5978
$ git pull https://git.openjdk.java.net/jdk pull/5978/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5978

View PR using the GUI difftool:
$ git pr show -t 5978

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5978.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 17, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 17, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Oct 17, 2021
@turbanoff turbanoff changed the title [PATCH] Change nested classes in jdk.jdi to static nested classes 8275385: Change nested classes in jdk.jdi to static nested classes Oct 18, 2021
@openjdk openjdk bot added the rfr label Oct 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 18, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275385: Change nested classes in jdk.jdi to static nested classes

Reviewed-by: sspitsyn, amenkov, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 389 new commits pushed to the master branch:

  • db0c8d5: 8274232: Cleanup unnecessary null comparison before instanceof check in jdk.jdi
  • 1830b8d: 8275056: Virtualize G1CardSet containers over heap region
  • fe45835: 8274856: Failing jpackage tests with fastdebug/release build
  • 9046077: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional
  • 7fc344d: 8277028: Use service type documentation as fallback for @provides
  • 35a831d: 8272170: Missing memory barrier when checking active state for regions
  • 02f7900: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp
  • fdcd16a: 8277048: Tiny improvements to the specification text for java.util.Properties.load
  • b231f5b: 8276921: G1: Remove redundant failed evacuation regions calculation in RemoveSelfForwardPtrHRClosure
  • ca2efb7: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • ... and 379 more: https://git.openjdk.java.net/jdk/compare/31500692d1503cb73249e0425e6930aaaa49258a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sspitsyn, @alexmenkov, @plummercj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 18, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 21, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@turbanoff
Your change (at version a1cabdc) is now ready to be sponsored by a Committer.

@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Nov 15, 2021

keep open

@plummercj
Copy link
Contributor

@plummercj plummercj commented Nov 15, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

Going to push as commit 7a87041.
Since your change was applied there have been 389 commits pushed to the master branch:

  • db0c8d5: 8274232: Cleanup unnecessary null comparison before instanceof check in jdk.jdi
  • 1830b8d: 8275056: Virtualize G1CardSet containers over heap region
  • fe45835: 8274856: Failing jpackage tests with fastdebug/release build
  • 9046077: 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional
  • 7fc344d: 8277028: Use service type documentation as fallback for @provides
  • 35a831d: 8272170: Missing memory barrier when checking active state for regions
  • 02f7900: 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp
  • fdcd16a: 8277048: Tiny improvements to the specification text for java.util.Properties.load
  • b231f5b: 8276921: G1: Remove redundant failed evacuation regions calculation in RemoveSelfForwardPtrHRClosure
  • ca2efb7: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend
  • ... and 379 more: https://git.openjdk.java.net/jdk/compare/31500692d1503cb73249e0425e6930aaaa49258a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@plummercj @turbanoff Pushed as commit 7a87041.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the static_nested_classes_jdk.jdi branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
4 participants